You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/30 03:40:48 UTC

[GitHub] [apisix] membphis commented on a change in pull request #2132: feat: support different modes to pass host to upstream

membphis commented on a change in pull request #2132:
URL: https://github.com/apache/apisix/pull/2132#discussion_r479716656



##########
File path: apisix/admin/upstreams.lua
##########
@@ -77,6 +77,12 @@ local function check_upstream_conf(conf)
             return false, "invalid configuration: " .. err
         end
     end
+
+    -- only support single node for `node` mode currently
+    if conf.pass_host == "node" and conf.nodes and #conf.nodes > 1 then
+        return false, "only support single node for `node` mode currently."

Review comment:
       remove dot 
   
   `"only support single node for `node` mode currently"`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org