You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/03/22 06:56:25 UTC
[GitHub] [commons-lang] arturobernalg opened a new pull request #736: LANG-1652 - Check whether the given class has a public constructor
arturobernalg opened a new pull request #736:
URL: https://github.com/apache/commons-lang/pull/736
Determine whether the given class has a public constructor with the given signature, checking accessibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #736: LANG-1652 - Check whether the given class has a public constructor
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #736:
URL: https://github.com/apache/commons-lang/pull/736#issuecomment-804558119
[](https://coveralls.io/builds/38160849)
Coverage increased (+0.0003%) to 94.937% when pulling **60d73e2a4aabd24305e6b34ad5bd01af2da410d1 on arturobernalg:feature/LANG-1652** into **69c9593cc1da760bb4dbcf32f4ae755c54376b77 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #736: LANG-1652 - Check whether the given class has a public constructor
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #736:
URL: https://github.com/apache/commons-lang/pull/736#issuecomment-971695585
> > @arturobernalg
> > I am curious: Can this be used within Commons Lang itself?
>
> Hi @garydgregory We have a complete class dedicated to manipulate and access to the method of a class through reflections, so, IMO why not.
Not, because (1) It's not useable within Commons Lang itself, because current callers of getAccessibleConstructor(*) test and use the result of the call. So using this new API internally would cause getAccessibleConstructor() to be called more than once instead of once. And (2) because "why not" is not a use-case, so YAGNI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #736: LANG-1652 - Check whether the given class has a public constructor
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #736:
URL: https://github.com/apache/commons-lang/pull/736#issuecomment-939070879
@arturobernalg
I am curious: Can this be used within Commons Lang itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #736: LANG-1652 - Check whether the given class has a public constructor
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #736:
URL: https://github.com/apache/commons-lang/pull/736#issuecomment-804558119
[](https://coveralls.io/builds/39634360)
Coverage increased (+0.0003%) to 94.927% when pulling **ba70492e2ddaa89881f75a97ebd8ec45cb5488c6 on arturobernalg:feature/LANG-1652** into **950ab130d616a67c39921b1d8c2c5b877ee8ad55 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on pull request #736: LANG-1652 - Check whether the given class has a public constructor
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #736:
URL: https://github.com/apache/commons-lang/pull/736#issuecomment-939228598
> @arturobernalg
> I am curious: Can this be used within Commons Lang itself?
Hi @garydgregory
We have a complete class dedicated to manipulate and access to the method of a class through reflections, so, IMO why not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #736: LANG-1652 - Check whether the given class has a public constructor
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #736:
URL: https://github.com/apache/commons-lang/pull/736#issuecomment-804558119
[](https://coveralls.io/builds/42656977)
Coverage increased (+0.0003%) to 94.952% when pulling **1e1a4b820f184b05b6081c1ad6e2359399c24ed5 on arturobernalg:feature/LANG-1652** into **4ff5e2b9f98e5ca9dd105a2d08477e0371ae8832 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org