You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/15 14:38:24 UTC
[GitHub] [submarine] liuxunorg opened a new pull request #185:
SUBMARINE-388. [k8s-e2e] Update docker image every time k8s-test is executed
liuxunorg opened a new pull request #185: SUBMARINE-388. [k8s-e2e] Update docker image every time k8s-test is executed
URL: https://github.com/apache/submarine/pull/185
### What is this PR for?
The k8s-e2e travis test needs to use the latest compiled package.
Do a docker build so that you can test the latest code.
Now we are using the image we have released on the apache docker hub, so we can't test the latest code.
### What type of PR is it?
[Feature]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/SUBMARINE-388
### How should this be tested?
* https://travis-ci.org/liuxunorg/submarine/builds/650831518
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #185:
SUBMARINE-388. Rebuild submarine image every run k8s-test
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #185: SUBMARINE-388. Rebuild submarine image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r381675305
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,79 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two kind of integration tests.
+
+They are in the project's `submarine/submarine-test` directory, There are two modules, `e2e` and `test-k8s`.
+
+There are currently some differences between `e2e` and `test-k8s` in operation mode.
+
+Among them, `e2e` needs to deploy submarine locally, while `test-k8s` uses k8s to deploy submarine.
+
+These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
+
+## k8s test
+
+k8s test: When the user submits the code to his/her repository or the `apache/submarine` git repository, the travis test task will automatically start.
+
+test-k8s runs test cases in travis. It will first create a k8s cluster by using the kind tool in travis,
+
+and then compile and package the submarine project in `submarine-dist` directory to build a docker image.
+
+Then use this latest code build docker image in k8s Deploy a submarine system. Then run test case in the `test-k8s/..` directory.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] tangzhankun commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r379871244
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,56 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two integration tests.
+
+They are in the project's `submarine/submarine-test` directory, There are two modules, `e2e` and `test-k8s`.
+
+There are currently some differences between `e2e` and `test-k8s` in operation mode. Among them, `e2e` needs to deploy submarine locally, while `test-k8s` uses k8s to deploy submarine.
+
+These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
+
+## k8s test
+
+k8s test: When the user submits the code to himself or the `apache/submarine` git repository, the travis test task will automatically start.
+
+test-k8s runs test cases in travis. It will first create a k8s cluster by using the kind tool in travis, and then compile and package the submarine project in `submarine-dist` directory to build a docker image.
+
+Then use this latest code build docker image in k8s Deploy a submarine system. Then run test case in the `test-k8s/test` directory.
+
+
+## e2e test
+
+e2e tests can be unit tested locally and in travis,
Review comment:
can be ran both locally and in Travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] tangzhankun commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r379870112
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,56 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two integration tests.
Review comment:
two kind of integration tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #185:
SUBMARINE-388. Rebuild submarine image every run k8s-test
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #185: SUBMARINE-388. Rebuild submarine image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r381673857
##########
File path: submarine-cloud/Makefile
##########
@@ -34,20 +33,19 @@ LDFLAGS := -s -w \
.PHONY: build
build:
- $(GOBUILD) -o ./bin/$(BINARY_NAME) -v cmd/operator/main.go
+ GOOS=${GOOS} GOARCH=amd64 $(GOBUILD) -o ./bin/$(BINARY_NAME) -v cmd/operator/main.go
test:
- $(GOTEST) -v ./...
+ #$(GOTEST) -v ./...
Review comment:
Now, Test cases for submarine-cloud are not yet supported.
I will support it in next work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #185: SUBMARINE-388. Rebuild
submarine image every run k8s-test
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #185: SUBMARINE-388. Rebuild submarine image every run k8s-test
URL: https://github.com/apache/submarine/pull/185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #185: SUBMARINE-388.
Rebuild submarine image every run k8s-test
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #185: SUBMARINE-388. Rebuild submarine image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#issuecomment-588989314
@tangzhankun @yuanzac Thank you help review this PR.
Will merge if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] tangzhankun commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r379870241
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,56 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two integration tests.
+
+They are in the project's `submarine/submarine-test` directory, There are two modules, `e2e` and `test-k8s`.
+
+There are currently some differences between `e2e` and `test-k8s` in operation mode. Among them, `e2e` needs to deploy submarine locally, while `test-k8s` uses k8s to deploy submarine.
+
+These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
+
+## k8s test
+
+k8s test: When the user submits the code to himself or the `apache/submarine` git repository, the travis test task will automatically start.
Review comment:
to himself -> to his/her repository
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r381204045
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,79 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two kind of integration tests.
Review comment:
Change kind to kinds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #185:
SUBMARINE-388. Rebuild submarine image every run k8s-test
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #185: SUBMARINE-388. Rebuild submarine image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r381675347
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,79 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two kind of integration tests.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r380762034
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,56 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two integration tests.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r381206189
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,79 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two kind of integration tests.
+
+They are in the project's `submarine/submarine-test` directory, There are two modules, `e2e` and `test-k8s`.
+
+There are currently some differences between `e2e` and `test-k8s` in operation mode.
+
+Among them, `e2e` needs to deploy submarine locally, while `test-k8s` uses k8s to deploy submarine.
+
+These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
+
+## k8s test
+
+k8s test: When the user submits the code to his/her repository or the `apache/submarine` git repository, the travis test task will automatically start.
+
+test-k8s runs test cases in travis. It will first create a k8s cluster by using the kind tool in travis,
+
+and then compile and package the submarine project in `submarine-dist` directory to build a docker image.
+
+Then use this latest code build docker image in k8s Deploy a submarine system. Then run test case in the `test-k8s/..` directory.
Review comment:
Then use this latest code to build a docker image and deploy a submarine system in k8s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r380762109
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,56 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two integration tests.
+
+They are in the project's `submarine/submarine-test` directory, There are two modules, `e2e` and `test-k8s`.
+
+There are currently some differences between `e2e` and `test-k8s` in operation mode. Among them, `e2e` needs to deploy submarine locally, while `test-k8s` uses k8s to deploy submarine.
+
+These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
+
+## k8s test
+
+k8s test: When the user submits the code to himself or the `apache/submarine` git repository, the travis test task will automatically start.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r380762150
##########
File path: docs/development/IntegrationTest.md
##########
@@ -1,31 +1,56 @@
-<!---
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License. See accompanying LICENSE file.
+<!---
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
-->
# IntegrationTest
-## Run the existing tests.
+Submarine now supports two integration tests.
+
+They are in the project's `submarine/submarine-test` directory, There are two modules, `e2e` and `test-k8s`.
+
+There are currently some differences between `e2e` and `test-k8s` in operation mode. Among them, `e2e` needs to deploy submarine locally, while `test-k8s` uses k8s to deploy submarine.
+
+These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
+
+## k8s test
+
+k8s test: When the user submits the code to himself or the `apache/submarine` git repository, the travis test task will automatically start.
+
+test-k8s runs test cases in travis. It will first create a k8s cluster by using the kind tool in travis, and then compile and package the submarine project in `submarine-dist` directory to build a docker image.
+
+Then use this latest code build docker image in k8s Deploy a submarine system. Then run test case in the `test-k8s/test` directory.
+
+
+## e2e test
+
+e2e tests can be unit tested locally and in travis,
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #185:
SUBMARINE-388. Rebuild image every run k8s-test
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #185: SUBMARINE-388. Rebuild image every run k8s-test
URL: https://github.com/apache/submarine/pull/185#discussion_r381208278
##########
File path: submarine-cloud/Makefile
##########
@@ -34,20 +33,19 @@ LDFLAGS := -s -w \
.PHONY: build
build:
- $(GOBUILD) -o ./bin/$(BINARY_NAME) -v cmd/operator/main.go
+ GOOS=${GOOS} GOARCH=amd64 $(GOBUILD) -o ./bin/$(BINARY_NAME) -v cmd/operator/main.go
test:
- $(GOTEST) -v ./...
+ #$(GOTEST) -v ./...
Review comment:
Delete this line instead of add a comment "#"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org