You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by evthoriz <gi...@git.apache.org> on 2017/07/21 08:52:05 UTC
[GitHub] incubator-rocketmq pull request #132: [ROCKETMQ-248] make ConsumeFromWhere w...
GitHub user evthoriz opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/132
[ROCKETMQ-248] make ConsumeFromWhere work right
JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-248
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/evthoriz/incubator-rocketmq develop-my
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #132
----
commit 827ca7584b62cc8b6e5aa5b06b3b3e6fd56c88bc
Author: Kaiyuan Yu <yu...@qiyi.com>
Date: 2017-07-21T08:13:27Z
make ConsumeFromWhere work right
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
[](https://coveralls.io/builds/12789603)
Coverage increased (+0.2%) to 38.926% when pulling **f7b7b5b1d8b7536f69504fd9bbe68d2511d8865f on evthoriz:develop-my** into **98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
@evthoriz Thank you. Do you have a test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
@evthoriz we usually need some measure to verify our correction, no matter what you do. IMO, unit test is a effective practice when we coding. Looking forward to hear from you again :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
[](https://coveralls.io/builds/12789603)
Coverage increased (+0.2%) to 38.926% when pulling **f7b7b5b1d8b7536f69504fd9bbe68d2511d8865f on evthoriz:develop-my** into **98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
[](https://coveralls.io/builds/12490822)
Coverage decreased (-0.3%) to 38.442% when pulling **827ca7584b62cc8b6e5aa5b06b3b3e6fd56c88bc on evthoriz:develop-my** into **118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
@evthoriz Thanks, looking forward to your patch :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #132: [ROCKETMQ-248] make ConsumeFromWhere work rig...
Posted by evthoriz <gi...@git.apache.org>.
Github user evthoriz commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/132
@shroman @vongosling It seems that plenty of tests are associated with this modification, I will resubmit a patch when I complete the relevant integration test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---