You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/11 11:21:42 UTC

[GitHub] [pulsar] lhotari opened a new pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

lhotari opened a new pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918


   ### Motivation
   
   Fixes #8911, compiling a sub module individually in the sub module directory
   Previously, the maven build failed if executed in other than the root directory if the license or checkstyle checks were run since
   those plugins weren't able to find their configuration.
   
   ### Modifications
   
   - use the proposed solution of https://stackoverflow.com/a/37965143
     to set a property `pulsar.basedir` which contains the absolute path
     of the root directory.
     - all other solutions don't seem to work universally in all projects,
       for example `project.parent.basedir` isn't available in the
       root project and not all projects necessarily have the root project
       as their parent project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743791607


   /pulsarbot rerun-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743258857


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743701770


   @lhotari I pushed a change to make sql integration become more stable. otherwise, CI will not pass.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743279479


   pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743232763


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743279971


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743279479


   pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743466690


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #8918: [build] Use absolute path to locate license and checkstyle plugin config

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8918:
URL: https://github.com/apache/pulsar/pull/8918#issuecomment-743370329


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org