You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/03 10:32:41 UTC

[GitHub] [beam] mosche commented on a diff in pull request #24810: [Spark Dataset runner] Fix initialization of metrics accumulator on driver

mosche commented on code in PR #24810:
URL: https://github.com/apache/beam/pull/24810#discussion_r1060455934


##########
runners/spark/3/src/main/java/org/apache/beam/runners/spark/structuredstreaming/SparkStructuredStreamingRunner.java:
##########
@@ -222,7 +225,7 @@ private static Future<?> runAsync(Runnable task) {
     return future;
   }
 
-  private static @Nullable Runnable stopSparkSession(SparkSession session, boolean isProvided) {
+  private static @Nullable Runnable sparkStopFun(SparkSession session, boolean isProvided) {

Review Comment:
   `Function`, I'll rename to `sparkStopFn` 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org