You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Joern Huxhorn (JIRA)" <ji...@codehaus.org> on 2007/03/17 15:04:33 UTC

[jira] Created: (MCLEAN-25) Optionally don't delete the 'target ' directory

Optionally don't delete the  'target ' directory
------------------------------------------------

                 Key: MCLEAN-25
                 URL: http://jira.codehaus.org/browse/MCLEAN-25
             Project: Maven 2.x Clean Plugin
          Issue Type: New Feature
            Reporter: Joern Huxhorn


Would it be possible to add an option to the clean-plugin so only the content of the target folder(s) are deleted but not the directory itself?

This would help developers using windoze quite a lot since:
- clean fails if you happen to have opened a command line with target as the current dir.
- windoze closes explorer windows pointing to deleted directories, so you have to reopen the windows after a clean install

Those problems would both be solved by an option like deleteRoot=false or something.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCLEAN-25) Optionally don't delete the 'target ' directory

Posted by "Joern Huxhorn (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCLEAN-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113815 ] 

Joern Huxhorn commented on MCLEAN-25:
-------------------------------------

This isn't a windows handler problem but a windows "feature". You can't delete a directory that is the current directory of a cmd-console.

The real problem is that clean fails if it can't delete a root directory.

I don't know about any other handler problems that this patch doesn't fix but I just can't see whats so bad about my suggestion.

> Optionally don't delete the  'target ' directory
> ------------------------------------------------
>
>                 Key: MCLEAN-25
>                 URL: http://jira.codehaus.org/browse/MCLEAN-25
>             Project: Maven 2.x Clean Plugin
>          Issue Type: New Feature
>            Reporter: Joern Huxhorn
>            Assignee: Vincent Siveton
>             Fix For: 2.2
>
>         Attachments: clean-patch.patch
>
>
> Would it be possible to add an option to the clean-plugin so only the content of the target folder(s) are deleted but not the directory itself?
> This would help developers using windoze quite a lot since:
> - clean fails if you happen to have opened a command line with target as the current dir.
> - windoze closes explorer windows pointing to deleted directories, so you have to reopen the windows after a clean install
> Those problems would both be solved by an option like deleteRoot=false or something.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCLEAN-25) Optionally don't delete the 'target ' directory

Posted by "Joern Huxhorn (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCLEAN-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113832 ] 

Joern Huxhorn commented on MCLEAN-25:
-------------------------------------

Very nice, thank you!
This does not solve the problem of vanishing explorer-windows but it does solve our main problem of failed builds.
Can we expect a 2.2 release in the near future?

> Optionally don't delete the  'target ' directory
> ------------------------------------------------
>
>                 Key: MCLEAN-25
>                 URL: http://jira.codehaus.org/browse/MCLEAN-25
>             Project: Maven 2.x Clean Plugin
>          Issue Type: New Feature
>            Reporter: Joern Huxhorn
>            Assignee: Vincent Siveton
>             Fix For: 2.2
>
>         Attachments: clean-patch.patch
>
>
> Would it be possible to add an option to the clean-plugin so only the content of the target folder(s) are deleted but not the directory itself?
> This would help developers using windoze quite a lot since:
> - clean fails if you happen to have opened a command line with target as the current dir.
> - windoze closes explorer windows pointing to deleted directories, so you have to reopen the windows after a clean install
> Those problems would both be solved by an option like deleteRoot=false or something.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCLEAN-25) Optionally don't delete the 'target ' directory

Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCLEAN-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113823 ] 

Vincent Siveton commented on MCLEAN-25:
---------------------------------------

You could also use ignoreErrors parameter (see MCLEAN-22 )

> Optionally don't delete the  'target ' directory
> ------------------------------------------------
>
>                 Key: MCLEAN-25
>                 URL: http://jira.codehaus.org/browse/MCLEAN-25
>             Project: Maven 2.x Clean Plugin
>          Issue Type: New Feature
>            Reporter: Joern Huxhorn
>            Assignee: Vincent Siveton
>             Fix For: 2.2
>
>         Attachments: clean-patch.patch
>
>
> Would it be possible to add an option to the clean-plugin so only the content of the target folder(s) are deleted but not the directory itself?
> This would help developers using windoze quite a lot since:
> - clean fails if you happen to have opened a command line with target as the current dir.
> - windoze closes explorer windows pointing to deleted directories, so you have to reopen the windows after a clean install
> Those problems would both be solved by an option like deleteRoot=false or something.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MCLEAN-25) Optionally don't delete the 'target ' directory

Posted by "Joern Huxhorn (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCLEAN-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joern Huxhorn updated MCLEAN-25:
--------------------------------

    Attachment: clean-patch.patch

A patch that implements the desired functionality.

> Optionally don't delete the  'target ' directory
> ------------------------------------------------
>
>                 Key: MCLEAN-25
>                 URL: http://jira.codehaus.org/browse/MCLEAN-25
>             Project: Maven 2.x Clean Plugin
>          Issue Type: New Feature
>            Reporter: Joern Huxhorn
>         Attachments: clean-patch.patch
>
>
> Would it be possible to add an option to the clean-plugin so only the content of the target folder(s) are deleted but not the directory itself?
> This would help developers using windoze quite a lot since:
> - clean fails if you happen to have opened a command line with target as the current dir.
> - windoze closes explorer windows pointing to deleted directories, so you have to reopen the windows after a clean install
> Those problems would both be solved by an option like deleteRoot=false or something.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MCLEAN-25) Optionally don't delete the 'target ' directory

Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCLEAN-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Siveton closed MCLEAN-25.
---------------------------------

         Assignee: Vincent Siveton
       Resolution: Won't Fix
    Fix Version/s: 2.2

This patch doesnt fix all other Windows handler pb.
I add a faq entry and you could download ProcessExplorer to close some handler.
http://www.microsoft.com/technet/sysinternals/Utilities/ProcessExplorer.mspx

> Optionally don't delete the  'target ' directory
> ------------------------------------------------
>
>                 Key: MCLEAN-25
>                 URL: http://jira.codehaus.org/browse/MCLEAN-25
>             Project: Maven 2.x Clean Plugin
>          Issue Type: New Feature
>            Reporter: Joern Huxhorn
>            Assignee: Vincent Siveton
>             Fix For: 2.2
>
>         Attachments: clean-patch.patch
>
>
> Would it be possible to add an option to the clean-plugin so only the content of the target folder(s) are deleted but not the directory itself?
> This would help developers using windoze quite a lot since:
> - clean fails if you happen to have opened a command line with target as the current dir.
> - windoze closes explorer windows pointing to deleted directories, so you have to reopen the windows after a clean install
> Those problems would both be solved by an option like deleteRoot=false or something.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MCLEAN-25) Optionally don't delete the 'target ' directory

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCLEAN-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MCLEAN-25:
----------------------------------

    Fix Version/s:     (was: 2.2)

Removing "Fix Version/s" because the resolution is "Won't Fix".

> Optionally don't delete the  'target ' directory
> ------------------------------------------------
>
>                 Key: MCLEAN-25
>                 URL: http://jira.codehaus.org/browse/MCLEAN-25
>             Project: Maven 2.x Clean Plugin
>          Issue Type: New Feature
>            Reporter: Joern Huxhorn
>            Assignee: Vincent Siveton
>         Attachments: clean-patch.patch
>
>
> Would it be possible to add an option to the clean-plugin so only the content of the target folder(s) are deleted but not the directory itself?
> This would help developers using windoze quite a lot since:
> - clean fails if you happen to have opened a command line with target as the current dir.
> - windoze closes explorer windows pointing to deleted directories, so you have to reopen the windows after a clean install
> Those problems would both be solved by an option like deleteRoot=false or something.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira