[GitHub] [drill] luocooong commented on a change in pull request #2241: DRILL-7938: Convert JDBC Storage Plugin to EVF

[GitBox <gi...@apache.org>]

luocooong commented on a change in pull request #2241:
URL: https://github.com/apache/drill/pull/2241#discussion_r643936655



##########
File path: contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithH2IT.java
##########
@@ -53,6 +54,10 @@
   @BeforeClass
   public static void init() throws Exception {
     startCluster(ClusterFixture.builder(dirTestWatcher));
+    // Force timezone to UTC for these tests.

Review comment:
       I recommend that :
   ```java
   
     private static TimeZone defaultTimeZone;
   
     @BeforeClass
     public static void setUp() {
       defaultTimeZone = TimeZone.getDefault();
       TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
     }
   
     @AfterClass
     public static void cleanUp() {
       TimeZone.setDefault(defaultTimeZone);
     }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org