You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2012/06/25 20:52:55 UTC
Review Request: HIVE-3100 : Add HiveCLI that runs over JDBC
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5554/
-----------------------------------------------------------
Review request for hive and Carl Steinbach.
Description
-------
New patch for supporting SQLLine as command line editor for Hive.
LICENSE and NOTICE updates to mention SQLLine
Build changes to add SQLLine
java wrapper to translate the CLI arguments to SQLLine
This addresses bug HIVE-3100.
https://issues.apache.org/jira/browse/HIVE-3100
Diffs
-----
LICENSE 05085da
NOTICE 871fdde
bin/ext/beeline.sh PRE-CREATION
eclipse-templates/HiveBeeLine.launchtemplate PRE-CREATION
ivy/ivysettings.xml fb6f4b8
ivy/libraries.properties 8461da1
jdbc/ivy.xml d8e3a5f
jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java PRE-CREATION
jdbc/src/java/org/apache/hive/jdbc/beeline/OptionsProcessor.java PRE-CREATION
Diff: https://reviews.apache.org/r/5554/diff/
Testing
-------
Thanks,
Prasad Mujumdar
Re: Review Request: HIVE-3100 : Add HiveCLI that runs over JDBC
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5554/#review8766
-----------------------------------------------------------
Ship it!
+1
- Carl Steinbach
On June 28, 2012, 2:10 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5554/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 2:10 a.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> New patch for supporting SQLLine as command line editor for Hive.
> LICENSE and NOTICE updates to mention SQLLine
> Build changes to add SQLLine
> java wrapper to translate the CLI arguments to SQLLine
>
>
> This addresses bug HIVE-3100.
> https://issues.apache.org/jira/browse/HIVE-3100
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/beeline.sh PRE-CREATION
> eclipse-templates/.classpath 49e9140
> eclipse-templates/HiveBeeLine.launchtemplate PRE-CREATION
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties c3b53bf
> jdbc/ivy.xml 9269bd1
> jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java PRE-CREATION
> jdbc/src/java/org/apache/hive/jdbc/beeline/OptionsProcessor.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5554/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request: HIVE-3100 : Add HiveCLI that runs over JDBC
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5554/
-----------------------------------------------------------
(Updated June 28, 2012, 2:10 a.m.)
Review request for hive and Carl Steinbach.
Changes
-------
Updates per review comments.
Description
-------
New patch for supporting SQLLine as command line editor for Hive.
LICENSE and NOTICE updates to mention SQLLine
Build changes to add SQLLine
java wrapper to translate the CLI arguments to SQLLine
This addresses bug HIVE-3100.
https://issues.apache.org/jira/browse/HIVE-3100
Diffs (updated)
-----
LICENSE 05085da
NOTICE 871fdde
bin/ext/beeline.sh PRE-CREATION
eclipse-templates/.classpath 49e9140
eclipse-templates/HiveBeeLine.launchtemplate PRE-CREATION
ivy/ivysettings.xml fb6f4b8
ivy/libraries.properties c3b53bf
jdbc/ivy.xml 9269bd1
jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java PRE-CREATION
jdbc/src/java/org/apache/hive/jdbc/beeline/OptionsProcessor.java PRE-CREATION
Diff: https://reviews.apache.org/r/5554/diff/
Testing
-------
Thanks,
Prasad Mujumdar
Re: Review Request: HIVE-3100 : Add HiveCLI that runs over JDBC
Posted by Prasad Mujumdar <pr...@cloudera.com>.
> On June 26, 2012, 7:46 p.m., Carl Steinbach wrote:
> > eclipse-templates/HiveBeeLine.launchtemplate, line 1
> > <https://reviews.apache.org/r/5554/diff/1/?file=116339#file116339line1>
> >
> > Please add sqlline to the eclipse classpath template in eclipse-files/.classpath
Done
> On June 26, 2012, 7:46 p.m., Carl Steinbach wrote:
> > jdbc/ivy.xml, line 36
> > <https://reviews.apache.org/r/5554/diff/1/?file=116342#file116342line36>
> >
> > This doesn't apply cleanly due to a change that went in a couple days ago. Needs a rebase.
Done
> On June 26, 2012, 7:46 p.m., Carl Steinbach wrote:
> > jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java, line 37
> > <https://reviews.apache.org/r/5554/diff/1/?file=116343#file116343line37>
> >
> > Remove.
Done
> On June 26, 2012, 7:46 p.m., Carl Steinbach wrote:
> > jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java, line 77
> > <https://reviews.apache.org/r/5554/diff/1/?file=116343#file116343line77>
> >
> > Remove?
yes, old code. Removed
> On June 26, 2012, 7:46 p.m., Carl Steinbach wrote:
> > jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java, line 113
> > <https://reviews.apache.org/r/5554/diff/1/?file=116343#file116343line113>
> >
> > Remove.
Done
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5554/#review8633
-----------------------------------------------------------
On June 25, 2012, 6:52 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5554/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 6:52 p.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> New patch for supporting SQLLine as command line editor for Hive.
> LICENSE and NOTICE updates to mention SQLLine
> Build changes to add SQLLine
> java wrapper to translate the CLI arguments to SQLLine
>
>
> This addresses bug HIVE-3100.
> https://issues.apache.org/jira/browse/HIVE-3100
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/beeline.sh PRE-CREATION
> eclipse-templates/HiveBeeLine.launchtemplate PRE-CREATION
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
> jdbc/ivy.xml d8e3a5f
> jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java PRE-CREATION
> jdbc/src/java/org/apache/hive/jdbc/beeline/OptionsProcessor.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5554/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request: HIVE-3100 : Add HiveCLI that runs over JDBC
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5554/#review8633
-----------------------------------------------------------
eclipse-templates/HiveBeeLine.launchtemplate
<https://reviews.apache.org/r/5554/#comment18269>
Please add sqlline to the eclipse classpath template in eclipse-files/.classpath
jdbc/ivy.xml
<https://reviews.apache.org/r/5554/#comment18268>
This doesn't apply cleanly due to a change that went in a couple days ago. Needs a rebase.
jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java
<https://reviews.apache.org/r/5554/#comment18271>
Remove.
jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java
<https://reviews.apache.org/r/5554/#comment18270>
Remove?
jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java
<https://reviews.apache.org/r/5554/#comment18272>
Remove.
- Carl Steinbach
On June 25, 2012, 6:52 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5554/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 6:52 p.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> New patch for supporting SQLLine as command line editor for Hive.
> LICENSE and NOTICE updates to mention SQLLine
> Build changes to add SQLLine
> java wrapper to translate the CLI arguments to SQLLine
>
>
> This addresses bug HIVE-3100.
> https://issues.apache.org/jira/browse/HIVE-3100
>
>
> Diffs
> -----
>
> LICENSE 05085da
> NOTICE 871fdde
> bin/ext/beeline.sh PRE-CREATION
> eclipse-templates/HiveBeeLine.launchtemplate PRE-CREATION
> ivy/ivysettings.xml fb6f4b8
> ivy/libraries.properties 8461da1
> jdbc/ivy.xml d8e3a5f
> jdbc/src/java/org/apache/hive/jdbc/beeline/HiveBeeline.java PRE-CREATION
> jdbc/src/java/org/apache/hive/jdbc/beeline/OptionsProcessor.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5554/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasad Mujumdar
>
>