You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/01/25 03:54:04 UTC

[GitHub] zeppelin pull request #2746: ZEPEPELIN-3190. Should not use singleton for Fi...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2746

    ZEPEPELIN-3190. Should not use singleton for FileSystemStorage

    ### What is this PR for?
    For now, `FileSystemNotebookRepo`, `FileSystemConfigStorage`, `FileSystemRecoveryStorage` use `FileSystemStorage`, but the singleton pattern means that all the notebook, config and recovery need to be stored in the same storage which might not be proper for some users. So this PR is trying to use separate `FileSystemStorage` instance for `FileSystemNotebookRepo`, `FileSystemConfigStorage`, `FileSystemRecoveryStorage` 
    
    
    ### What type of PR is it?
    [Bug Fix | Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3190
    
    ### How should this be tested?
    * Travis pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3190

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2746
    
----
commit e0441c59c9590b20cbbc71d9b8ac116ee563b716
Author: Jeff Zhang <zj...@...>
Date:   2018-01-25T01:50:48Z

    ZPEPELIN-3190. Should not use singleton for FileSystemStorage

----


---

[GitHub] zeppelin issue #2746: ZEPEPELIN-3190. Should not use singleton for FileSyste...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2746
  
    @prabhjyotsingh Please help review it, Thanks


---

[GitHub] zeppelin pull request #2746: ZEPPELIN-3190. Should not use singleton for Fil...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2746


---