Re: [PR] [WIP][SPARK-54652] Complete conversion of IDENTIFIER() [spark]

["srielau (via GitHub)" <gi...@apache.org>]

srielau commented on code in PR #53407:
URL: https://github.com/apache/spark/pull/53407#discussion_r2603734135


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -4529,7 +4529,7 @@ class AstBuilder extends DataTypeAstBuilder
       case applyCtx: ApplyTransformContext =>
         val arguments = applyCtx.argument.asScala.map(visitTransformArgument).toSeq
 
-        applyCtx.identifier.getText match {
+        getIdentifierText(applyCtx.identifier) match {

Review Comment:
   Does not apply here. These are keywords "BUCKET", "YEARS" etc.
   Teh grammar should (fix if needed) not allow IDENTIFIER here. See the EXTRACT function grammar.
   Same applies for other places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org