You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/05/05 07:09:30 UTC
[GitHub] [skywalking-java] wu-sheng commented on pull request #524: Fix SQLServer write data intercept failure (#10741)
wu-sheng commented on PR #524:
URL: https://github.com/apache/skywalking-java/pull/524#issuecomment-1535818840
```
[INFO] Starting audit...
Error: /home/runner/work/skywalking-java/skywalking-java/apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/PSSetterDefinitionOfJDBCInstrumentation.java:27:52: Using the '.*' form of import should be avoided - net.bytebuddy.matcher.ElementMatchers.*. [AvoidStarImport]
Audit done.
[INFO] There is 1 error reported by Checkstyle 9.3 with /home/runner/work/skywalking-java/skywalking-java/apm-checkstyle/checkStyle.xml ruleset.
Error: src/main/java/org/apache/skywalking/apm/plugin/jdbc/PSSetterDefinitionOfJDBCInstrumentation.java:[27,52] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - net.bytebuddy.matcher.ElementMatchers.*.
```
It seems you don't check the code style locally.
And you should update the changelog according to the PR template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org