[GitHub] [geode-native] gaussianrecurrence edited a comment on pull request #715: GEODE-8793: Fix PdxTypeRegistry cleanup

[GitBox <gi...@apache.org>]

gaussianrecurrence edited a comment on pull request #715:
URL: https://github.com/apache/geode-native/pull/715#issuecomment-785990080


   Since it has passed some time since I last updated this PR here is a little update:
   
   - I've changed the behaviour of PdxTypeRegistry cleanup. Now is cleaned up whenever the are no more alive endpoints in the pool, rather than whenever connections are exhausted. This was changed because if the cluster is restarted and no requests were being executed meanwhile it could happen that the registry was not cleaned up. But, on the other hand endpoint liveness is controlled by periodic ping requests which are regularly sent.
   - I've noticed a edge case in which the client can crash if the registry is cleaned up while PdxHelper::serializePdx is being called. I've created an issue to tackle that problem: https://issues.apache.org/jira/browse/GEODE-8968
   - I've noticed a quite concerning bug having to do with throwExceptionIfError, which I solved for the specific case but I created a new Jira ticket to tackle all the cases: https://issues.apache.org/jira/browse/GEODE-8973


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org