You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/14 00:26:21 UTC
[GitHub] [hudi] alexeykudinkin opened a new pull request, #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
alexeykudinkin opened a new pull request, #5319:
URL: https://github.com/apache/hudi/pull/5319
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
Right now, any `HoodieAsyncService` would be awaiting for 24h for its executor to shutdown gracefully. This however poses a problem in cases when such executor is spinning non-daemon threads, as this might prevent JVM from shutting down for those 24h, in cases when executors continue running (for ex, in a crash loop).
## Brief change log
- Reducing executor graceful shutdown timeout to 1m from 24h
- Fixed `DeltaSyncService` to properly override `shutdown` method and invoke one from super-class for proper shutting down
- Cleaning up some NPEs previously observed in tests
- Tidying up
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
This pull request is already covered by existing tests, such as *(please describe tests)*.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5319:
URL: https://github.com/apache/hudi/pull/5319#issuecomment-1100291962
please create a jira and tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5319:
URL: https://github.com/apache/hudi/pull/5319#issuecomment-1098598458
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "815ccb2926df7f374760a5d27fef42398461d07c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8060",
"triggerID" : "815ccb2926df7f374760a5d27fef42398461d07c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 815ccb2926df7f374760a5d27fef42398461d07c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8060)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5319:
URL: https://github.com/apache/hudi/pull/5319#issuecomment-1098597186
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "815ccb2926df7f374760a5d27fef42398461d07c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "815ccb2926df7f374760a5d27fef42398461d07c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 815ccb2926df7f374760a5d27fef42398461d07c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5319:
URL: https://github.com/apache/hudi/pull/5319#issuecomment-1098630016
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "815ccb2926df7f374760a5d27fef42398461d07c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8060",
"triggerID" : "815ccb2926df7f374760a5d27fef42398461d07c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 815ccb2926df7f374760a5d27fef42398461d07c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8060)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on PR #5319:
URL: https://github.com/apache/hudi/pull/5319#issuecomment-1120229680
Will take a pass once this is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5319:
URL: https://github.com/apache/hudi/pull/5319#issuecomment-1284916324
@alexeykudinkin : can we close this one if not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin closed pull request #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin closed pull request #5319: [WIP] Adjusting `DeltaStreamer` shutdown sequence to avoid awaiting for 24h
URL: https://github.com/apache/hudi/pull/5319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org