You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/02/13 16:21:58 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #39997: [SPARK-42424][YARN] Remove unused method `setEnvFromInputString` from YarnSparkHadoopUtil
LuciferYang opened a new pull request, #39997:
URL: https://github.com/apache/spark/pull/39997
### What changes were proposed in this pull request?
`YarnSparkHadoopUtil#setEnvFromInputString` becomes a unused method after SPARK-17979, this pr just remove it.
### Why are the changes needed?
Code clean up.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #39997: [SPARK-42424][YARN] Remove unused method `setEnvFromInputString` from YarnSparkHadoopUtil
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #39997:
URL: https://github.com/apache/spark/pull/39997#issuecomment-1430687508
cc @HyukjinKwon @srowen @dongjoon-hyun @tgravescs @mridulm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #39997:
URL: https://github.com/apache/spark/pull/39997#issuecomment-1430848804
> Maybe just YARN to start
Should be no more cases in Yarn source code (this pr not include test code now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #39997: [SPARK-42424][YARN] Remove unused method `setEnvFromInputString` from YarnSparkHadoopUtil
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #39997:
URL: https://github.com/apache/spark/pull/39997#issuecomment-1430693232
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
URL: https://github.com/apache/spark/pull/39997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #39997: [SPARK-42424][YARN] Remove unused method `setEnvFromInputString` from YarnSparkHadoopUtil
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #39997:
URL: https://github.com/apache/spark/pull/39997#issuecomment-1430691447
> Sounds fine, is there more unused code we can just prune all at once?
I think there should be, in what scope? Yarn module scope or Spark project scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #39997: [SPARK-42424][YARN] Remove unused method `setEnvFromInputString` from YarnSparkHadoopUtil
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #39997:
URL: https://github.com/apache/spark/pull/39997#issuecomment-1430692568
Maybe just YARN to start
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39997:
URL: https://github.com/apache/spark/pull/39997#discussion_r1107197472
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -595,7 +595,7 @@ private[spark] class ApplicationMaster(
}
failureCount = 0
} catch {
- case i: InterruptedException => // do nothing
+ case _: InterruptedException => // do nothing
Review Comment:
Yeah, if it's not important, I can roll back these. They are in a commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39997:
URL: https://github.com/apache/spark/pull/39997#discussion_r1107197472
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -595,7 +595,7 @@ private[spark] class ApplicationMaster(
}
failureCount = 0
} catch {
- case i: InterruptedException => // do nothing
+ case _: InterruptedException => // do nothing
Review Comment:
Yeah, if it's not important, I can revert these. They are in a commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39997:
URL: https://github.com/apache/spark/pull/39997#discussion_r1107197472
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -595,7 +595,7 @@ private[spark] class ApplicationMaster(
}
failureCount = 0
} catch {
- case i: InterruptedException => // do nothing
+ case _: InterruptedException => // do nothing
Review Comment:
Yeah, if it's not important, I can revert these. They are in the same commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #39997:
URL: https://github.com/apache/spark/pull/39997#discussion_r1107195817
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -595,7 +595,7 @@ private[spark] class ApplicationMaster(
}
failureCount = 0
} catch {
- case i: InterruptedException => // do nothing
+ case _: InterruptedException => // do nothing
Review Comment:
These are not important, but OK if we're just doing cleanup. Seems OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #39997:
URL: https://github.com/apache/spark/pull/39997#issuecomment-1430846169
[92f9b38](https://github.com/apache/spark/pull/39997/commits/92f9b38d0641d3db7c751e9d155fbacb3df776a2) include used local vars, please let me know if you don't need to change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #39997:
URL: https://github.com/apache/spark/pull/39997#issuecomment-1433262619
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39997: [SPARK-42424][YARN] Remove unused declarations from Yarn module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39997:
URL: https://github.com/apache/spark/pull/39997#discussion_r1107206306
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -595,7 +595,7 @@ private[spark] class ApplicationMaster(
}
failureCount = 0
} catch {
- case i: InterruptedException => // do nothing
+ case _: InterruptedException => // do nothing
Review Comment:
@srowen [53a6bfa](https://github.com/apache/spark/pull/39997/commits/53a6bfa6373872e3a8edaa531486d82e593d0ea7) revert [92f9b38](https://github.com/apache/spark/pull/39997/commits/92f9b38d0641d3db7c751e9d155fbacb3df776a2) and update pr description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39997: [SPARK-42424][YARN] Remove unused method `setEnvFromInputString` from YarnSparkHadoopUtil
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39997:
URL: https://github.com/apache/spark/pull/39997#discussion_r1106600484
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -1174,4 +1174,4 @@
},
"nbformat": 4,
"nbformat_minor": 1
-}
Review Comment:
will revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org