You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/04/16 16:12:50 UTC
[GitHub] activemq-artemis pull request #2023: ARTEMIS-857 Add JMX endpoints to view a...
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2023
ARTEMIS-857 Add JMX endpoints to view and reset groups
Expose method to return current mappings of groups to consumers
Expose methods to reset (remove) specific group mapping from groupID to Consumer
Expose methods to reset (remove) all group mappings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-857
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2023.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2023
----
commit c28a27d5db942d2a148adaff2e0b90f4863233f1
Author: Michael André Pearce <mi...@...>
Date: 2018-04-16T16:11:44Z
ARTEMIS-857 Add JMX endpoints to view and reset groups
Expose method to return current mappings of groups to consumers
Expose methods to reset (remove) specific group mapping from groupID to Consumer
Expose methods to reset (remove) all group mappings
----
---
[GitHub] activemq-artemis pull request #2023: ARTEMIS-857 Add JMX endpoints to view a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2023
---
[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2023
At the core layer it’s called group eg that’s the name within core message, and other settings around this.
I’ll add test though.
---
[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2023
@michaelandrepearce The code is fine I think. It'll be nice you add some unittests (e.g. in QueueControlTest) to verify it works. Also I find that the "Group" in method names a bit confusing.
Would be using MessageGoup instead more clear? I'm not sure about that as I'm not a native speaker, just a personal opinion.
---
[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2023
Just working through the low hanging fruit thats needed to unblock artemis to become activemq 6.
as per:
http://activemq.apache.org/activemq-artemis-roadmap.html
---
[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2023
Test case added to QueueControlTest
---