You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/20 20:42:57 UTC
[GitHub] [pinot] siddharthteotia commented on a change in pull request #7935: exit group-by marking loop early
siddharthteotia commented on a change in pull request #7935:
URL: https://github.com/apache/pinot/pull/7935#discussion_r772656228
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##########
@@ -270,6 +270,9 @@ private void processSingleValue(int numDocs, int[] dictIds, int[] outGroupIds) {
if (!_flags[outGroupIds[i]]) {
_numKeys++;
_flags[outGroupIds[i]] = true;
+ if (_numKeys == _globalGroupIdUpperBound) {
Review comment:
Seems like the change was intended for conditional exit for low cardinality. I don't think that's what is happening here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org