You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/01 00:02:25 UTC

[GitHub] [cloudstack] ravening opened a new pull request #4364: Check if host is suitable for migration of VM

ravening opened a new pull request #4364:
URL: https://github.com/apache/cloudstack/pull/4364


   ## Description
   
   If a vm is running on non dedicated host then all the hosts
   which are dedicated for other accounts/domain should not be
   eligible for migration.
   
   Similarly if a vm is running on dedicated host then all the hosts
   which are only dedicated for this account/domain should be
   eligible for migration
   
   Steps to reproducde the issue:
   
   1. Dedicate a host to root/admin
   2. create a account test, and create a vm
   3. Try to migrate the vm
   4. Open the dialog to migrate the vm
   
   Expected result:
   The dedicated host for root domain should be "Not Suitable" for migration
   
   Actual result:
   The ui shows the "dedicated host" as "Suitable"
   
   Test cases:
   
   Create a test account.
   Create 1 vm under root domain and 1 under test domain
   
   1. Try to migrate a vm of root domain
   2. All hosts should be suitable for migration - PASS
   3. Same result for the vm of test domain - PASS
   
   1. Dedicate a different host to root domain
   2. Try to migrate vm of root domain
   3. All hosts should be suitable for migration since vm is running on
      non dedicated host and the other hosts are either non dedicated
      or dedicated to root domain - PASS
   4. Try to migrate vm of test domain. The host which was dedicated above
      should be not suitable for migration as it is dedicated to different
      domain - PASS
   
   1. Try to dedicate the host on which vm of root domain running to root domain
   2. Try to migrate the vm of root domain.
   3. All hosts should be not suitable since source host is dedicated and no other
      hosts are dedicated -PASS
   4. Try to migrate vm of test domain
   5. All hosts except the host which is dedicated to root domain should be not
      suitable for migration. - PASS
   
   Do the same above steps but with dedicating a host to test domain instead of root domain
   
   
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4364: Check if host is suitable for migration of VM

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4364:
URL: https://github.com/apache/cloudstack/pull/4364#issuecomment-701911578


   @ravening this has been fixed by #4001


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] svenvogel commented on pull request #4364: Check if host is suitable for migration of VM

Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #4364:
URL: https://github.com/apache/cloudstack/pull/4364#issuecomment-712738008


   @weizhouapache @ravening is this already fixed and can be closed or? i am confused 😄 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening closed pull request #4364: Check if host is suitable for migration of VM

Posted by GitBox <gi...@apache.org>.
ravening closed pull request #4364:
URL: https://github.com/apache/cloudstack/pull/4364


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org