You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/09/08 08:54:40 UTC
[GitHub] [logging-log4net] NicholasNoise opened a new pull request #66: Fix net40 client profile
NicholasNoise opened a new pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] NicholasNoise commented on pull request #66: Fix net40 client profile
Posted by GitBox <gi...@apache.org>.
NicholasNoise commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-693265610
@fluffynuts last Thursday or this one? =)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] NicholasNoise commented on pull request #66: Fix net40 client profile
Posted by GitBox <gi...@apache.org>.
NicholasNoise commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688843984
> @cremor
>
> Some of those are the same as are now manually defined in the log4net.csproj and some are different. This might be confusing for developers who don't check if the constants are defined by the project itself.
>
> But it also seems like migration to the official constants is not that easy. Because with them it seems like the version specific constants are **not** enabled for lower versions when a higher version is built.
You're right, no other way about it. Build-in features are preferable.
But it seems unnecessary since this project is dormant.
I've spent almost two working day to enable netstandard2.0, so yes, is not easy... until old targets are supported.
Should be much easier without legacy preprocessor symbols like 'NETCF', 'CLIENT_PROFILE' and even 'NET20'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] cremor commented on pull request #66: Fix net40 client profile
Posted by GitBox <gi...@apache.org>.
cremor commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688832079
Not directly related to this PR, but since you are modifying the preprocessor symbols (constants) here I thought I should mention this:
SDK style projects already define various target framework related constants automatically, see https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives/preprocessor-if#remarks
Some of those are the same as are now manually defined in the log4net.csproj and some are different. This might be confusing for developers who don't check if the constants are defined by the project itself.
But it also seems like migration to the official constants is not that easy. Because with them it seems like the version specific constants are **not** enabled for lower versions when a higher version is built.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts commented on pull request #66: Fix net40 client profile
Posted by GitBox <gi...@apache.org>.
fluffynuts commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-693971008
Sorry, been a bit mad -- the day off turned into a mission (:
anyway, LGTM, merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] NicholasNoise commented on pull request #66: Fix net40 client profile
Posted by GitBox <gi...@apache.org>.
NicholasNoise commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688829374
@fluffynuts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts merged pull request #66: Fix net40 client profile
Posted by GitBox <gi...@apache.org>.
fluffynuts merged pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts commented on pull request #66: Fix net40 client profile
Posted by GitBox <gi...@apache.org>.
fluffynuts commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-689052738
LGTM; when I have a moment, I'd like to pull down to my machine & build again to double-check; I'm taking a day off from work tomorrow, so perhaps Thursday (:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org