You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ravi Phulari (JIRA)" <ji...@apache.org> on 2009/10/15 09:48:31 UTC

[jira] Created: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

"bin/hadoop fs -help count"  fails to show help about only "count" command. 
----------------------------------------------------------------------------

                 Key: HADOOP-6314
                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: Ravi Phulari


Currently "hadoop fs -help count" fails to show help about only count command. 
Instead it displays following output

{noformat}
[rphulari@statepick-lm]> bin/hadoop fs -help count
hadoop fs is the command to execute fs commands. The full syntax is: 

hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
	[-tail [-f] <path>] [-text <path>]

..
..
..

{noformat}

Expected output of "bin/hadoop fs -help count " should be 
{noformat}
[rphulari@statepick-lm]> bin/hadoop  fs -help count
-count[-q] <path>: Count the number of directories, files and bytes under the paths
		that match the specified file pattern.  The output columns are:
		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
{noformat}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Ravi Phulari (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Phulari updated HADOOP-6314:
---------------------------------

    Attachment: CountHelp.patch

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ravi Phulari
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-6314:
-------------------------------------------

    Status: Patch Available  (was: Open)

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Ravi Phulari
>            Assignee: Ravi Phulari
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777886#action_12777886 ] 

Hudson commented on HADOOP-6314:
--------------------------------

Integrated in Hadoop-Common-trunk #158 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/158/])
    . Fix "fs -help" for the "-count" commond.  Contributed by Ravi Phulari


> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Ravi Phulari
>            Assignee: Ravi Phulari
>             Fix For: 0.22.0
>
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Ravi Phulari (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766473#action_12766473 ] 

Ravi Phulari commented on HADOOP-6314:
--------------------------------------

Nicholas, Thanks for suggestion, I have attached updated patch.
Gary, Thanks for pointing it out , I have created HADOOP-6316 for adding missing unit tests .

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ravi Phulari
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-6314:
-------------------------------------------

     Component/s: fs
        Assignee: Ravi Phulari
    Hadoop Flags: [Reviewed]

+1 patch looks good.

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Ravi Phulari
>            Assignee: Ravi Phulari
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "gary murry (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766135#action_12766135 ] 

gary murry commented on HADOOP-6314:
------------------------------------

Please create a jira for the missing unit tests and mark it as blocked by Hadoop-6222.

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ravi Phulari
>         Attachments: CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777354#action_12777354 ] 

Hadoop QA commented on HADOOP-6314:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12422334/CountHelp.patch
  against trunk revision 833553.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/136/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/136/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/136/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/136/console

This message is automatically generated.

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Ravi Phulari
>            Assignee: Ravi Phulari
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781424#action_12781424 ] 

Hudson commented on HADOOP-6314:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #91 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/91/])
    . Fix "fs -help" for the "-count" commond.  Contributed by Ravi Phulari


> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Ravi Phulari
>            Assignee: Ravi Phulari
>             Fix For: 0.22.0
>
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Ravi Phulari (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Phulari updated HADOOP-6314:
---------------------------------

    Attachment: CountHelp.patch

Patch does not include Unit tests because there is no TestCLI in core. Jira HADOOP-6222


ant test-patch results 

{noformt}
 [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] ======================================================================
     [exec] ======================================================================
     [exec]     Finished build.
     [exec] ======================================================================
     [exec] ======================================================================
     [exec] 
     [exec] 

BUILD SUCCESSFUL
Total time: 20 minutes 22 seconds
{noformat}

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ravi Phulari
>         Attachments: CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Ravi Phulari (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777303#action_12777303 ] 

Ravi Phulari commented on HADOOP-6314:
--------------------------------------

Test patch result against trunk.

{noformat}
 [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] ======================================================================
     [exec] ======================================================================
     [exec]     Finished build.
     [exec] ======================================================================
     [exec] ======================================================================
     [exec] 
{noformat}

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Ravi Phulari
>            Assignee: Ravi Phulari
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-6314:
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
           Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Ravi!

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Ravi Phulari
>            Assignee: Ravi Phulari
>             Fix For: 0.22.0
>
>         Attachments: CountHelp.patch, CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6314) "bin/hadoop fs -help count" fails to show help about only "count" command.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766145#action_12766145 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6314:
------------------------------------------------

Count.matches(..) is used by some other codes.  Changing it will affect the "fs -count" command.

The correct fix is to revert the following.
{code}
@@ -1493,7 +1458,7 @@
       System.out.println(chown);
     } else if ("chgrp".equals(cmd)) {
       System.out.println(chgrp);
-    } else if (Count.NAME.equals(cmd)) {
+    } else if (Count.matches(cmd)) {
       System.out.println(Count.DESCRIPTION);
     } else if ("help".equals(cmd)) {
       System.out.println(help);
{code}

> "bin/hadoop fs -help count"  fails to show help about only "count" command. 
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-6314
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6314
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ravi Phulari
>         Attachments: CountHelp.patch
>
>
> Currently "hadoop fs -help count" fails to show help about only count command. 
> Instead it displays following output
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop fs -help count
> hadoop fs is the command to execute fs commands. The full syntax is: 
> hadoop fs [-fs <local | file system URI>] [-conf <configuration file>]
> 	[-D <property=value>] [-ls <path>] [-lsr <path>] [-df [<path>]] [-du <path>]
> 	[-dus <path>] [-mv <src> <dst>] [-cp <src> <dst>] [-rm [-skipTrash] <src>]
> 	[-rmr [-skipTrash] <src>] [-put <localsrc> ... <dst>] [-copyFromLocal <localsrc> ... <dst>]
> 	[-moveFromLocal <localsrc> ... <dst>] [-get [-ignoreCrc] [-crc] <src> <localdst>
> 	[-getmerge <src> <localdst> [addnl]] [-cat <src>]
> 	[-copyToLocal [-ignoreCrc] [-crc] <src> <localdst>] [-moveToLocal <src> <localdst>]
> 	[-mkdir <path>] [-report] [-setrep [-R] [-w] <rep> <path/file>]
> 	[-touchz <path>] [-test -[ezd] <path>] [-stat [format] <path>]
> 	[-tail [-f] <path>] [-text <path>]
> ..
> ..
> ..
> {noformat}
> Expected output of "bin/hadoop fs -help count " should be 
> {noformat}
> [rphulari@statepick-lm]> bin/hadoop  fs -help count
> -count[-q] <path>: Count the number of directories, files and bytes under the paths
> 		that match the specified file pattern.  The output columns are:
> 		DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME or
> 		QUOTA REMAINING_QUATA SPACE_QUOTA REMAINING_SPACE_QUOTA 
> 		      DIR_COUNT FILE_COUNT CONTENT_SIZE FILE_NAME
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.