You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "DhroovSankla (via GitHub)" <gi...@apache.org> on 2026/10/04 13:16:35 UTC

[PR] FINERACT-2889: Migrate PaymentTypeIntegrationTest to Feign client [fineract]

DhroovSankla opened a new pull request, #6569:
URL: https://github.com/apache/fineract/pull/6569

   ## Description
   Migrate legacy `PaymentTypeIntegrationTest` from the deprecated RestAssured setup to the type-safe Feign client API as part of ongoing technical debt remediation.
   
   Jira Ticket: [FINERACT-2889](https://issues.apache.org/jira/browse/FINERACT-2889)
   
   ## Changes
   - Moved `PaymentTypeIntegrationTest` to the `org.apache.fineract.integrationtests.client` package and renamed class to `PaymentTypeTest`.
   - Refactored test cases to utilize type-safe Feign client endpoints via `IntegrationTest`.
   - Removed legacy RestAssured imports, `RequestSpecification`/`ResponseSpecification` setup, and explicit login calls.
   - Updated `PaymentTypeHelper` and related references to align with Feign client response models.
   
   ## Checklist
   - [x] Code complies with spotless code formatting rules (`./gradlew spotlessApply`)
   - [x] Checkstyle tests pass cleanly (`./gradlew :integration-tests:checkstyleTest`)
   - [x] Local integration tests verified successfully


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2889: Migrate PaymentTypeIntegrationTest to Feign client [fineract]

Posted by "DhroovSankla (via GitHub)" <gi...@apache.org>.
DhroovSankla closed pull request #6569: FINERACT-2889: Migrate PaymentTypeIntegrationTest to Feign client
URL: https://github.com/apache/fineract/pull/6569


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2889: Migrate PaymentTypeIntegrationTest to Feign client [fineract]

Posted by "DhroovSankla (via GitHub)" <gi...@apache.org>.
DhroovSankla commented on PR #6569:
URL: https://github.com/apache/fineract/pull/6569#issuecomment-6109349583

   @adamsaghy 
   Looking forward for your review!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2889: Migrate PaymentTypeIntegrationTest to Feign client [fineract]

Posted by "DhroovSankla (via GitHub)" <gi...@apache.org>.
DhroovSankla commented on PR #6569:
URL: https://github.com/apache/fineract/pull/6569#issuecomment-6229300535

   > Hi @DhroovSankla, this is already covered by #6559, which migrated this test to Feign. This branch also uses the Retrofit `IntegrationTest`, not Feign. I'd suggest closing this PR.
   
   Thanks for clarifying!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org