You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2022/10/18 15:29:00 UTC
[jira] [Comment Edited] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619582#comment-17619582 ]
Ekaterina Dimitrova edited comment on CASSANDRA-17873 at 10/18/22 3:28 PM:
---------------------------------------------------------------------------
[~benedict] , It's been some time since I dig that docs, I will look again whether I missed something by chance and post here for completeness.
On the other hand, looking now you use it with the simulator and run java 8 tests? I am no expert with the simulator but I assume if you run jdk8 tests and you use there already that opcode this was checked? I might be missing something though, so happy to be corrected.
PS ASM7 stands for the asm version and JDK11 official support was added in 7, experimental in 6, we had 5 here
was (Author: e.dimitrova):
[~benedict] , It's been some time since I dig that docs, I will look again whether I missed something by chance and post here for completeness.
On the other hand, looking now you use it with the simulator and run java 8 tests? I am no expert with the simulator but I assume if you run jdk8 tests and you use there already that opcode this was checked? I might be missing something though, so happy to be corrected.
> Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
> -------------------------------------------------------------------
>
> Key: CASSANDRA-17873
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17873
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Dependencies, Feature/UDF
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x
>
>
> In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to provide Opcodes.ASM7 but only in 1 of 3 places.
> We need to update that for 4.0, 4.1 and trunk where we support JDK11.
> Also, I think it will be good to add one place where we update that when we add new JDK support as now I see we will have to update it at 4 places at least already (also for the simulator where currently it is Opcodes.ASM7 there, correctly added). Also, we can add a note in build.xml for people updating ASM. I think many people practice updating Opcodes.ASM* with the update of ASM version but in our case with update of JDK, from what I see. We will need to switch to ASM9 when we add the JDK 17 support. One stop place for that and adding a note for maintainers sounds like the right way to move forward at least on trunk.
> But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I can tell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org