You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/10 21:15:22 UTC
[GitHub] [pulsar] merlimat opened a new pull request #7507: The test should wait until the worker leader is ready, otherwise the request to create function will fail
merlimat opened a new pull request #7507:
URL: https://github.com/apache/pulsar/pull/7507
### Motivation
The function test is failing if the request is being made while the leader is still initializing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #7507: The test should wait until the worker leader is ready, otherwise the request to create function will fail
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7507:
URL: https://github.com/apache/pulsar/pull/7507#discussion_r453086632
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##########
@@ -1493,6 +1493,7 @@ public void testPulsarFunctionStatus() throws Exception {
@Test(dataProvider = "validRoleName")
public void testAuthorization(boolean validRoleName) throws Exception {
+ functionsWorkerService.getLeaderService().waitLeaderInit();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7507: The test should wait until the worker leader is ready, otherwise the request to create function will fail
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7507:
URL: https://github.com/apache/pulsar/pull/7507#discussion_r453082083
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##########
@@ -1493,6 +1493,7 @@ public void testPulsarFunctionStatus() throws Exception {
@Test(dataProvider = "validRoleName")
public void testAuthorization(boolean validRoleName) throws Exception {
+ functionsWorkerService.getLeaderService().waitLeaderInit();
Review comment:
I would put this in the setup method
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##########
@@ -1493,6 +1493,7 @@ public void testPulsarFunctionStatus() throws Exception {
@Test(dataProvider = "validRoleName")
public void testAuthorization(boolean validRoleName) throws Exception {
+ functionsWorkerService.getLeaderService().waitLeaderInit();
Review comment:
at the end of the setup method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #7507: The test should wait until the worker leader is ready, otherwise the request to create function will fail
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #7507:
URL: https://github.com/apache/pulsar/pull/7507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org