You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by András Piros <an...@cloudera.com> on 2016/09/30 15:47:13 UTC
Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit
build
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
Review request for oozie and Robert Kanter.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs
-----
bin/test-patch-11-findbugs-diff PRE-CREATION
pom.xml 704a2ee
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
> On Oct. 7, 2016, 2:22 p.m., Attila Sasvari wrote:
> > bin/test-patch-11-findbugs-diff, line 121
> > <https://reviews.apache.org/r/52429/diff/3/?file=1526278#file1526278line121>
> >
> > Should not we clean up / delete this directory at the end of the execution?
> >
> >
> > If not and we decide to keep the jar / directory for some reason, then it is not necessary to download findbugs diff jar each time. For example it can happen that jenkins jobs run on the same build server. In this case we could just reuse the already downloaded jar (if its md5 checksum is OK). What do you think?
After performing FindBugs diff analysis both the JAR and the MD5 files are removed.
- Andr�s
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/#review151797
-----------------------------------------------------------
On Oct. 7, 2016, 10:39 a.m., Andr�s Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52429/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2016, 10:39 a.m.)
>
>
> Review request for oozie and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> We go for that solution:
>
> 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
>
> 2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
>
> 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
>
> 4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
>
> 5. have the reports merged and be downloadable in any case in following scenarios:
>
> * -1 for bugs that are too serious to apply the patch with them
> * 0 for other new bugs
> * +1 if there is no new bug
>
>
> Diffs
> -----
>
> bin/test-patch-11-findbugs-diff PRE-CREATION
> bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
> pom.xml a33d2c5
>
> Diff: https://reviews.apache.org/r/52429/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andr�s Piros
>
>
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by Attila Sasvari <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/#review151797
-----------------------------------------------------------
bin/test-patch-11-findbugs-diff (line 121)
<https://reviews.apache.org/r/52429/#comment220321>
Should not we clean up / delete this directory at the end of the execution?
If not and we decide to keep the jar / directory for some reason, then it is not necessary to download findbugs diff jar each time. For example it can happen that jenkins jobs run on the same build server. In this case we could just reuse the already downloaded jar (if its md5 checksum is OK). What do you think?
- Attila Sasvari
On Oct. 7, 2016, 10:39 a.m., Andr�s Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52429/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2016, 10:39 a.m.)
>
>
> Review request for oozie and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> We go for that solution:
>
> 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
>
> 2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
>
> 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
>
> 4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
>
> 5. have the reports merged and be downloadable in any case in following scenarios:
>
> * -1 for bugs that are too serious to apply the patch with them
> * 0 for other new bugs
> * +1 if there is no new bug
>
>
> Diffs
> -----
>
> bin/test-patch-11-findbugs-diff PRE-CREATION
> bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
> pom.xml a33d2c5
>
> Diff: https://reviews.apache.org/r/52429/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andr�s Piros
>
>
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/#review152303
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Cseh
On Oct. 10, 2016, 12:28 p.m., Andr�s Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52429/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2016, 12:28 p.m.)
>
>
> Review request for oozie and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> We go for that solution:
>
> 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
>
> 2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
>
> 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
>
> 4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
>
> 5. have the reports merged and be downloadable in any case in following scenarios:
>
> * -1 for bugs that are too serious to apply the patch with them
> * 0 for other new bugs
> * +1 if there is no new bug
>
>
> Diffs
> -----
>
> bin/test-patch-11-findbugs-diff PRE-CREATION
> bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
> pom.xml a33d2c5
>
> Diff: https://reviews.apache.org/r/52429/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andr�s Piros
>
>
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
> On Oct. 12, 2016, 2 p.m., Attila Sasvari wrote:
> > bin/test-patch-11-findbugs-diff, line 179
> > <https://reviews.apache.org/r/52429/diff/2-4/?file=1518708#file1518708line179>
> >
> > You can move theses two lines to cleanup_and_exit() if possible
> > rm -f "${DIFF_DIR}/${FINDBUGS_JAR}" "${DIFF_DIR}/${FINDBUGS_JAR}.md5"
> > echo "[TRACE] FindBugs diff JAR removed"
> > (add an if that tests if jar and md5 are there)
> >
> > call cleanup_and_exit at the end in the report switch case
Done.
- Andr�s
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/#review152302
-----------------------------------------------------------
On Oct. 12, 2016, 2:45 p.m., Andr�s Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52429/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2016, 2:45 p.m.)
>
>
> Review request for oozie and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> We go for that solution:
>
> 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
>
> 2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
>
> 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
>
> 4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
>
> 5. have the reports merged and be downloadable in any case in following scenarios:
>
> * -1 for bugs that are too serious to apply the patch with them
> * 0 for other new bugs
> * +1 if there is no new bug
>
>
> Diffs
> -----
>
> bin/test-patch-11-findbugs-diff PRE-CREATION
> bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
> pom.xml 83a1d42
>
> Diff: https://reviews.apache.org/r/52429/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andr�s Piros
>
>
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by Attila Sasvari <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/#review152302
-----------------------------------------------------------
bin/test-patch-11-findbugs-diff (line 179)
<https://reviews.apache.org/r/52429/#comment221275>
You can move theses two lines to cleanup_and_exit() if possible
rm -f "${DIFF_DIR}/${FINDBUGS_JAR}" "${DIFF_DIR}/${FINDBUGS_JAR}.md5"
echo "[TRACE] FindBugs diff JAR removed"
(add an if that tests if jar and md5 are there)
call cleanup_and_exit at the end in the report switch case
- Attila Sasvari
On Oct. 10, 2016, 12:28 p.m., Andr�s Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52429/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2016, 12:28 p.m.)
>
>
> Review request for oozie and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> We go for that solution:
>
> 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
>
> 2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
>
> 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
>
> 4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
>
> 5. have the reports merged and be downloadable in any case in following scenarios:
>
> * -1 for bugs that are too serious to apply the patch with them
> * 0 for other new bugs
> * +1 if there is no new bug
>
>
> Diffs
> -----
>
> bin/test-patch-11-findbugs-diff PRE-CREATION
> bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
> pom.xml a33d2c5
>
> Diff: https://reviews.apache.org/r/52429/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andr�s Piros
>
>
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by Attila Sasvari <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/#review152327
-----------------------------------------------------------
bin/test-patch-11-findbugs-diff (line 49)
<https://reviews.apache.org/r/52429/#comment221310>
(nit) remove whitespace
- Attila Sasvari
On Oct. 12, 2016, 3:07 p.m., Andr�s Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52429/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2016, 3:07 p.m.)
>
>
> Review request for oozie and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> We go for that solution:
>
> 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
>
> 2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
>
> 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
>
> 4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
>
> 5. have the reports merged and be downloadable in any case in following scenarios:
>
> * -1 for bugs that are too serious to apply the patch with them
> * 0 for other new bugs
> * +1 if there is no new bug
>
>
> Diffs
> -----
>
> bin/test-patch-11-findbugs-diff PRE-CREATION
> bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
> pom.xml 83a1d42
>
> Diff: https://reviews.apache.org/r/52429/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andr�s Piros
>
>
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 26, 2016, 9:23 a.m.)
Review request for oozie and Robert Kanter.
Changes
-------
`bin/*` is excluded from RAT analysis.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
bin/test-patch-11-findbugs-diff 0376ab0788644633982bfb099e740566b3b7118e
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 28179b6921d1b3ead4f87fca581b03bd62c0f013
pom.xml ade1f250106daff83022dc9954cadea5addcacfd
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 24, 2016, 1:42 p.m.)
Review request for oozie and Robert Kanter.
Changes
-------
MD5 related issue and others are fixed.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
bin/test-patch-11-findbugs-diff 0376ab0788644633982bfb099e740566b3b7118e
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 28179b6921d1b3ead4f87fca581b03bd62c0f013
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 17, 2016, 12:25 p.m.)
Review request for oozie and Robert Kanter.
Changes
-------
Going for the `v0.1.0-all` package from Maven Central instead of GitHub.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/test-patch-11-findbugs-diff PRE-CREATION
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
pom.xml 83a1d42
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by Attila Sasvari <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/#review152482
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Sasvari
On Oct. 12, 2016, 4:08 p.m., Andr�s Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52429/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2016, 4:08 p.m.)
>
>
> Review request for oozie and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> We go for that solution:
>
> 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
>
> 2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
>
> 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
>
> 4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
>
> 5. have the reports merged and be downloadable in any case in following scenarios:
>
> * -1 for bugs that are too serious to apply the patch with them
> * 0 for other new bugs
> * +1 if there is no new bug
>
>
> Diffs
> -----
>
> bin/test-patch-11-findbugs-diff PRE-CREATION
> bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
> pom.xml 83a1d42
>
> Diff: https://reviews.apache.org/r/52429/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andr�s Piros
>
>
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 12, 2016, 4:08 p.m.)
Review request for oozie and Robert Kanter.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/test-patch-11-findbugs-diff PRE-CREATION
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
pom.xml 83a1d42
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 12, 2016, 3:07 p.m.)
Review request for oozie and Robert Kanter.
Changes
-------
Some other piece of small refactor.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/test-patch-11-findbugs-diff PRE-CREATION
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
pom.xml 83a1d42
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 12, 2016, 2:45 p.m.)
Review request for oozie and Robert Kanter.
Changes
-------
Small refactor.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/test-patch-11-findbugs-diff PRE-CREATION
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
pom.xml 83a1d42
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 10, 2016, 12:28 p.m.)
Review request for oozie and Robert Kanter.
Changes
-------
Some lines were broken so that these can fit into 132 chars. For some others it's not feasible being String constants.
We also delete the JAR file and the MD5 file after having checked.
Moreover, in the summary file we also enlist the most severe errors.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/test-patch-11-findbugs-diff PRE-CREATION
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
pom.xml a33d2c5
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 7, 2016, 10:39 a.m.)
Review request for oozie and Robert Kanter.
Changes
-------
Some small refactor in order to have method names more bash-ish.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/test-patch-11-findbugs-diff PRE-CREATION
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
pom.xml a33d2c5
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros
Re: Review Request 52429: OOZIE-1986 Add FindBugs report to
pre-commit build
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52429/
-----------------------------------------------------------
(Updated Oct. 3, 2016, 11:26 a.m.)
Review request for oozie and Robert Kanter.
Changes
-------
Check that the downloaded FindBugs JAR file has the same MD5 as expected.
Repository: oozie-git
Description
-------
We go for that solution:
1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile
2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder
3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs
4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold
5. have the reports merged and be downloadable in any case in following scenarios:
* -1 for bugs that are too serious to apply the patch with them
* 0 for other new bugs
* +1 if there is no new bug
Diffs (updated)
-----
bin/test-patch-11-findbugs-diff PRE-CREATION
bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION
pom.xml 29184b2
Diff: https://reviews.apache.org/r/52429/diff/
Testing
-------
Thanks,
Andr�s Piros