You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2021/11/20 20:09:21 UTC
[maven-resolver-ant-tasks] branch master updated: [MRESOLVER-212] Use final variables whenever possible
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-resolver-ant-tasks.git
The following commit(s) were added to refs/heads/master by this push:
new e4c1cfd [MRESOLVER-212] Use final variables whenever possible
e4c1cfd is described below
commit e4c1cfdf64df860431478e5b9456550ce1b24e7f
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Sun Oct 3 10:10:05 2021 +0200
[MRESOLVER-212] Use final variables whenever possible
This closes #10
---
.../maven/resolver/internal/ant/AetherUtils.java | 20 ++++++-------
.../maven/resolver/internal/ant/AntLogger.java | 10 +++----
.../resolver/internal/ant/AntModelResolver.java | 30 +++++++++----------
.../maven/resolver/internal/ant/AntRepoSys.java | 12 ++++----
.../internal/ant/AntRepositoryListener.java | 20 ++++++-------
.../ant/AntServiceLocatorErrorHandler.java | 4 +--
.../internal/ant/AntSettingsDecryptorFactory.java | 2 +-
.../resolver/internal/ant/AntTransferListener.java | 20 ++++++-------
.../internal/ant/tasks/AbstractDistTask.java | 34 +++++++++++-----------
.../internal/ant/tasks/AbstractResolvingTask.java | 12 ++++----
.../resolver/internal/ant/types/Artifact.java | 22 +++++++-------
11 files changed, 93 insertions(+), 93 deletions(-)
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/AetherUtils.java b/src/main/java/org/apache/maven/resolver/internal/ant/AetherUtils.java
index 6b59f90..d2f6054 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/AetherUtils.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/AetherUtils.java
@@ -27,16 +27,16 @@ import org.apache.tools.ant.Project;
class AetherUtils
{
- public static File findGlobalSettings( Project project )
+ public static File findGlobalSettings( final Project project )
{
- File file = new File( new File( project.getProperty( "ant.home" ), "etc" ), Names.SETTINGS_XML );
+ final File file = new File( new File( project.getProperty( "ant.home" ), "etc" ), Names.SETTINGS_XML );
if ( file.isFile() )
{
return file;
}
else
{
- String mavenHome = getMavenHome( project );
+ final String mavenHome = getMavenHome( project );
if ( mavenHome != null )
{
return new File( new File( mavenHome, "conf" ), Names.SETTINGS_XML );
@@ -46,9 +46,9 @@ class AetherUtils
return null;
}
- public static String getMavenHome( Project project )
+ public static String getMavenHome( final Project project )
{
- String mavenHome = project.getProperty( "maven.home" );
+ final String mavenHome = project.getProperty( "maven.home" );
if ( mavenHome != null )
{
return mavenHome;
@@ -56,10 +56,10 @@ class AetherUtils
return System.getenv( "M2_HOME" );
}
- public static File findUserSettings( Project project )
+ public static File findUserSettings( final Project project )
{
- File userHome = new File( project.getProperty( "user.home" ) );
- File file = new File( new File( userHome, ".ant" ), Names.SETTINGS_XML );
+ final File userHome = new File( project.getProperty( "user.home" ) );
+ final File file = new File( new File( userHome, ".ant" ), Names.SETTINGS_XML );
if ( file.isFile() )
{
return file;
@@ -70,9 +70,9 @@ class AetherUtils
}
}
- public static RemoteRepositories getDefaultRepositories( Project project )
+ public static RemoteRepositories getDefaultRepositories( final Project project )
{
- Object obj = project.getReference( Names.ID_DEFAULT_REPOS );
+ final Object obj = project.getReference( Names.ID_DEFAULT_REPOS );
if ( obj instanceof RemoteRepositories )
{
return (RemoteRepositories) obj;
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/AntLogger.java b/src/main/java/org/apache/maven/resolver/internal/ant/AntLogger.java
index f71aecf..9fa9ded 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/AntLogger.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/AntLogger.java
@@ -30,17 +30,17 @@ class AntLogger
private Project project;
- AntLogger( Project project )
+ AntLogger( final Project project )
{
this.project = project;
}
- public void debug( String msg )
+ public void debug( final String msg )
{
project.log( msg, Project.MSG_DEBUG );
}
- public void debug( String msg, Throwable error )
+ public void debug( final String msg, final Throwable error )
{
project.log( msg, error, Project.MSG_DEBUG );
}
@@ -55,12 +55,12 @@ class AntLogger
return true;
}
- public void warn( String msg )
+ public void warn( final String msg )
{
project.log( msg, Project.MSG_WARN );
}
- public void warn( String msg, Throwable error )
+ public void warn( final String msg, final Throwable error )
{
project.log( msg, error, Project.MSG_WARN );
}
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/AntModelResolver.java b/src/main/java/org/apache/maven/resolver/internal/ant/AntModelResolver.java
index 8de7957..acdf730 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/AntModelResolver.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/AntModelResolver.java
@@ -64,8 +64,8 @@ class AntModelResolver
private final Set<String> repositoryIds;
- AntModelResolver( RepositorySystemSession session, String context, RepositorySystem repoSys,
- RemoteRepositoryManager remoteRepositoryManager, List<RemoteRepository> repositories )
+ AntModelResolver( final RepositorySystemSession session, final String context, final RepositorySystem repoSys,
+ final RemoteRepositoryManager remoteRepositoryManager, final List<RemoteRepository> repositories )
{
this.session = session;
this.context = context;
@@ -75,7 +75,7 @@ class AntModelResolver
this.repositoryIds = new HashSet<String>();
}
- private AntModelResolver( AntModelResolver original )
+ private AntModelResolver( final AntModelResolver original )
{
this.session = original.session;
this.context = original.context;
@@ -85,7 +85,7 @@ class AntModelResolver
this.repositoryIds = new HashSet<String>( original.repositoryIds );
}
- public void addRepository( Repository repository )
+ public void addRepository( final Repository repository )
throws InvalidRepositoryException
{
if ( !repositoryIds.add( repository.getId() ) )
@@ -93,22 +93,22 @@ class AntModelResolver
return;
}
- List<RemoteRepository> newRepositories = Collections.singletonList( convert( repository ) );
+ final List<RemoteRepository> newRepositories = Collections.singletonList( convert( repository ) );
this.repositories =
remoteRepositoryManager.aggregateRepositories( session, repositories, newRepositories, true );
}
- static RemoteRepository convert( Repository repository )
+ static RemoteRepository convert( final Repository repository )
{
- RemoteRepository.Builder builder =
+ final RemoteRepository.Builder builder =
new RemoteRepository.Builder( repository.getId(), repository.getLayout(), repository.getUrl() );
builder.setSnapshotPolicy( convert( repository.getSnapshots() ) );
builder.setReleasePolicy( convert( repository.getReleases() ) );
return builder.build();
}
- private static RepositoryPolicy convert( org.apache.maven.model.RepositoryPolicy policy )
+ private static RepositoryPolicy convert( final org.apache.maven.model.RepositoryPolicy policy )
{
boolean enabled = true;
String checksums = RepositoryPolicy.CHECKSUM_POLICY_WARN;
@@ -135,43 +135,43 @@ class AntModelResolver
return new AntModelResolver( this );
}
- public ModelSource resolveModel( String groupId, String artifactId, String version )
+ public ModelSource resolveModel( final String groupId, final String artifactId, final String version )
throws UnresolvableModelException
{
Artifact pomArtifact = new DefaultArtifact( groupId, artifactId, "", "pom", version );
try
{
- ArtifactRequest request = new ArtifactRequest( pomArtifact, repositories, context );
+ final ArtifactRequest request = new ArtifactRequest( pomArtifact, repositories, context );
pomArtifact = repoSys.resolveArtifact( session, request ).getArtifact();
}
- catch ( ArtifactResolutionException e )
+ catch ( final ArtifactResolutionException e )
{
throw new UnresolvableModelException( "Failed to resolve POM for " + groupId + ":" + artifactId + ":"
+ version + " due to " + e.getMessage(), groupId, artifactId, version, e );
}
- File pomFile = pomArtifact.getFile();
+ final File pomFile = pomArtifact.getFile();
return new FileModelSource( pomFile );
}
@Override
- public ModelSource resolveModel( Parent parent )
+ public ModelSource resolveModel( final Parent parent )
throws UnresolvableModelException
{
return resolveModel( parent.getGroupId(), parent.getArtifactId(), parent.getVersion() );
}
@Override
- public ModelSource resolveModel( Dependency dependency )
+ public ModelSource resolveModel( final Dependency dependency )
throws UnresolvableModelException
{
return resolveModel( dependency.getGroupId(), dependency.getArtifactId(), dependency.getVersion() );
}
@Override
- public void addRepository( Repository repository, boolean replace )
+ public void addRepository( final Repository repository, final boolean replace )
throws InvalidRepositoryException
{
addRepository( repository );
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/AntRepoSys.java b/src/main/java/org/apache/maven/resolver/internal/ant/AntRepoSys.java
index 51ed961..beaa6c5 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/AntRepoSys.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/AntRepoSys.java
@@ -227,7 +227,7 @@ public class AntRepoSys
{
DefaultRepositorySystemSession session = MavenRepositorySystemUtils.newSession();
- Map<Object, Object> configProps = new LinkedHashMap<>();
+ final Map<Object, Object> configProps = new LinkedHashMap<>();
configProps.put( ConfigurationProperties.USER_AGENT, getUserAgent() );
configProps.putAll( (Map<?, ?>) project.getProperties() );
processServerConfiguration( configProps );
@@ -309,7 +309,7 @@ public class AntRepoSys
private Map<String, String> getHttpHeaders( Xpp3Dom dom )
{
- Map<String, String> headers = new HashMap<>();
+ final Map<String, String> headers = new HashMap<>();
for ( int i = 0; i < dom.getChildCount(); i++ )
{
Xpp3Dom child = dom.getChild( i );
@@ -435,7 +435,7 @@ public class AntRepoSys
{
DefaultAuthenticationSelector selector = new DefaultAuthenticationSelector();
- Collection<String> ids = new HashSet<>();
+ final Collection<String> ids = new HashSet<>();
for ( Authentication auth : authentications )
{
List<String> servers = auth.getServers();
@@ -735,7 +735,7 @@ public class AntRepoSys
globalExclusions.addAll( dependencies.getExclusions() );
}
- Collection<String> ids = new HashSet<>();
+ final Collection<String> ids = new HashSet<>();
for ( DependencyContainer container : dependencies.getDependencyContainers() )
{
@@ -804,7 +804,7 @@ public class AntRepoSys
private List<Dependency> readDependencies( File file )
{
- List<Dependency> dependencies = new ArrayList<>();
+ final List<Dependency> dependencies = new ArrayList<>();
try
{
try ( BufferedReader reader = new BufferedReader( new InputStreamReader( new FileInputStream( file ), "UTF-8" ) ) )
@@ -878,7 +878,7 @@ public class AntRepoSys
Model model = pom.getModel( task );
File pomFile = pom.getFile();
- List<org.eclipse.aether.artifact.Artifact> results = new ArrayList<>();
+ final List<org.eclipse.aether.artifact.Artifact> results = new ArrayList<>();
org.eclipse.aether.artifact.Artifact pomArtifact =
new DefaultArtifact( model.getGroupId(), model.getArtifactId(), "pom", model.getVersion() ).setFile( pomFile );
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/AntRepositoryListener.java b/src/main/java/org/apache/maven/resolver/internal/ant/AntRepositoryListener.java
index 077fc26..4f5ff94 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/AntRepositoryListener.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/AntRepositoryListener.java
@@ -36,27 +36,27 @@ class AntRepositoryListener
private Task task;
- AntRepositoryListener( Task task )
+ AntRepositoryListener( final Task task )
{
this.task = task;
}
@Override
- public void artifactInstalling( RepositoryEvent event )
+ public void artifactInstalling( final RepositoryEvent event )
{
task.log( "Installing " + event.getArtifact().getFile() + " to " + event.getFile() );
}
@Override
- public void metadataInstalling( RepositoryEvent event )
+ public void metadataInstalling( final RepositoryEvent event )
{
task.log( "Installing " + event.getMetadata() + " to " + event.getFile() );
}
@Override
- public void metadataResolved( RepositoryEvent event )
+ public void metadataResolved( final RepositoryEvent event )
{
- Exception e = event.getException();
+ final Exception e = event.getException();
if ( e != null )
{
if ( e instanceof MetadataNotFoundException )
@@ -71,11 +71,11 @@ class AntRepositoryListener
}
@Override
- public void metadataInvalid( RepositoryEvent event )
+ public void metadataInvalid( final RepositoryEvent event )
{
- Exception exception = event.getException();
+ final Exception exception = event.getException();
- StringBuilder buffer = new StringBuilder( 256 );
+ final StringBuilder buffer = new StringBuilder( 256 );
buffer.append( "The metadata " );
if ( event.getMetadata().getFile() != null )
{
@@ -105,7 +105,7 @@ class AntRepositoryListener
}
@Override
- public void artifactDescriptorInvalid( RepositoryEvent event )
+ public void artifactDescriptorInvalid( final RepositoryEvent event )
{
task.log( "The POM for " + event.getArtifact() + " is invalid"
+ ", transitive dependencies (if any) will not be available: "
@@ -114,7 +114,7 @@ class AntRepositoryListener
};
@Override
- public void artifactDescriptorMissing( RepositoryEvent event )
+ public void artifactDescriptorMissing( final RepositoryEvent event )
{
task.log( "The POM for " + event.getArtifact() + " is missing, no dependency information available",
Project.MSG_WARN );
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/AntServiceLocatorErrorHandler.java b/src/main/java/org/apache/maven/resolver/internal/ant/AntServiceLocatorErrorHandler.java
index e6af28a..7de3455 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/AntServiceLocatorErrorHandler.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/AntServiceLocatorErrorHandler.java
@@ -31,12 +31,12 @@ class AntServiceLocatorErrorHandler
private Project project;
- AntServiceLocatorErrorHandler( Project project )
+ AntServiceLocatorErrorHandler( final Project project )
{
this.project = project;
}
- public void serviceCreationFailed( Class<?> type, Class<?> impl, Throwable exception )
+ public void serviceCreationFailed( final Class<?> type, final Class<?> impl, final Throwable exception )
{
String msg = "Could not initialize repository system";
if ( !RepositorySystem.class.equals( type ) )
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/AntSettingsDecryptorFactory.java b/src/main/java/org/apache/maven/resolver/internal/ant/AntSettingsDecryptorFactory.java
index bfa2e07..01c898f 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/AntSettingsDecryptorFactory.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/AntSettingsDecryptorFactory.java
@@ -28,7 +28,7 @@ class AntSettingsDecryptorFactory
public DefaultSettingsDecrypter newInstance()
{
- AntSecDispatcher secDispatcher = new AntSecDispatcher();
+ final AntSecDispatcher secDispatcher = new AntSecDispatcher();
return new DefaultSettingsDecrypter( secDispatcher );
}
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/AntTransferListener.java b/src/main/java/org/apache/maven/resolver/internal/ant/AntTransferListener.java
index b36e637..9a88ef8 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/AntTransferListener.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/AntTransferListener.java
@@ -39,13 +39,13 @@ class AntTransferListener
private Task task;
- AntTransferListener( Task task )
+ AntTransferListener( final Task task )
{
this.task = task;
}
@Override
- public void transferInitiated( TransferEvent event )
+ public void transferInitiated( final TransferEvent event )
throws TransferCancelledException
{
String msg = event.getRequestType() == TransferEvent.RequestType.PUT ? "Uploading" : "Downloading";
@@ -54,32 +54,32 @@ class AntTransferListener
}
@Override
- public void transferCorrupted( TransferEvent event )
+ public void transferCorrupted( final TransferEvent event )
throws TransferCancelledException
{
- TransferResource resource = event.getResource();
+ final TransferResource resource = event.getResource();
task.log( event.getException().getMessage() + " for " + resource.getRepositoryUrl()
+ resource.getResourceName(), Project.MSG_WARN );
}
@Override
- public void transferSucceeded( TransferEvent event )
+ public void transferSucceeded( final TransferEvent event )
{
String msg = event.getRequestType() == TransferEvent.RequestType.PUT ? "Uploaded" : "Downloaded";
msg += " " + event.getResource().getRepositoryUrl() + event.getResource().getResourceName();
- long contentLength = event.getTransferredBytes();
+ final long contentLength = event.getTransferredBytes();
if ( contentLength >= 0 )
{
- String len = contentLength >= 1024 ? ( ( contentLength + 1023 ) / 1024 ) + " KB" : contentLength + " B";
+ final String len = contentLength >= 1024 ? ( ( contentLength + 1023 ) / 1024 ) + " KB" : contentLength + " B";
String throughput = "";
- long duration = System.currentTimeMillis() - event.getResource().getTransferStartTime();
+ final long duration = System.currentTimeMillis() - event.getResource().getTransferStartTime();
if ( duration > 0 )
{
- DecimalFormat format = new DecimalFormat( "0.0", new DecimalFormatSymbols( Locale.ENGLISH ) );
- double kbPerSec = ( contentLength / 1024.0 ) / ( duration / 1000.0 );
+ final DecimalFormat format = new DecimalFormat( "0.0", new DecimalFormatSymbols( Locale.ENGLISH ) );
+ final double kbPerSec = ( contentLength / 1024.0 ) / ( duration / 1000.0 );
throughput = " at " + format.format( kbPerSec ) + " KB/sec";
}
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/tasks/AbstractDistTask.java b/src/main/java/org/apache/maven/resolver/internal/ant/tasks/AbstractDistTask.java
index 70bebbc..12066a0 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/tasks/AbstractDistTask.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/tasks/AbstractDistTask.java
@@ -47,10 +47,10 @@ public abstract class AbstractDistTask
{
getArtifacts().validate( this );
- Map<String, File> duplicates = new HashMap<String, File>();
- for ( Artifact artifact : getArtifacts().getArtifacts() )
+ final Map<String, File> duplicates = new HashMap<String, File>();
+ for ( final Artifact artifact : getArtifacts().getArtifacts() )
{
- String key = artifact.getType() + ':' + artifact.getClassifier();
+ final String key = artifact.getType() + ':' + artifact.getClassifier();
if ( "pom:".equals( key ) )
{
throw new BuildException( "You must not specify an <artifact> with type=pom"
@@ -69,7 +69,7 @@ public abstract class AbstractDistTask
validateArtifactGav( artifact );
}
- Pom defaultPom = AntRepoSys.getInstance( getProject() ).getDefaultPom();
+ final Pom defaultPom = AntRepoSys.getInstance( getProject() ).getDefaultPom();
if ( pom == null && defaultPom != null )
{
log( "Using default POM (" + defaultPom.getCoords() + ")", Project.MSG_INFO );
@@ -87,17 +87,17 @@ public abstract class AbstractDistTask
}
}
- private void validateArtifactGav( Artifact artifact )
+ private void validateArtifactGav( final Artifact artifact )
{
- Pom artifactPom = artifact.getPom();
+ final Pom artifactPom = artifact.getPom();
if ( artifactPom != null )
{
- String gid;
- String aid;
- String version;
+ final String gid;
+ final String aid;
+ final String version;
if ( artifactPom.getFile() != null )
{
- Model model = artifactPom.getModel( this );
+ final Model model = artifactPom.getModel( this );
gid = model.getGroupId();
aid = model.getArtifactId();
version = model.getVersion();
@@ -109,7 +109,7 @@ public abstract class AbstractDistTask
version = artifactPom.getVersion();
}
- Model model = getPom().getModel( this );
+ final Model model = getPom().getModel( this );
if ( ! ( model.getGroupId().equals( gid ) && model.getArtifactId().equals( aid ) && model.getVersion().equals( version ) ) )
{
@@ -129,19 +129,19 @@ public abstract class AbstractDistTask
return artifacts;
}
- public void addArtifact( Artifact artifact )
+ public void addArtifact( final Artifact artifact )
{
getArtifacts().addArtifact( artifact );
}
- public void addArtifacts( Artifacts artifacts )
+ public void addArtifacts( final Artifacts artifacts )
{
getArtifacts().addArtifacts( artifacts );
}
- public void setArtifactsRef( Reference ref )
+ public void setArtifactsRef( final Reference ref )
{
- Artifacts artifacts = new Artifacts();
+ final Artifacts artifacts = new Artifacts();
artifacts.setProject( getProject() );
artifacts.setRefid( ref );
getArtifacts().addArtifacts( artifacts );
@@ -157,7 +157,7 @@ public abstract class AbstractDistTask
return pom;
}
- public void addPom( Pom pom )
+ public void addPom( final Pom pom )
{
if ( this.pom != null )
{
@@ -166,7 +166,7 @@ public abstract class AbstractDistTask
this.pom = pom;
}
- public void setPomRef( Reference ref )
+ public void setPomRef( final Reference ref )
{
if ( this.pom != null )
{
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/tasks/AbstractResolvingTask.java b/src/main/java/org/apache/maven/resolver/internal/ant/tasks/AbstractResolvingTask.java
index c19e086..941cfe2 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/tasks/AbstractResolvingTask.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/tasks/AbstractResolvingTask.java
@@ -41,7 +41,7 @@ public abstract class AbstractResolvingTask
protected LocalRepository localRepository;
- public void addDependencies( Dependencies dependencies )
+ public void addDependencies( final Dependencies dependencies )
{
if ( this.dependencies != null )
{
@@ -50,7 +50,7 @@ public abstract class AbstractResolvingTask
this.dependencies = dependencies;
}
- public void setDependenciesRef( Reference ref )
+ public void setDependenciesRef( final Reference ref )
{
if ( dependencies == null )
{
@@ -80,19 +80,19 @@ public abstract class AbstractResolvingTask
return remoteRepositories;
}
- public void addRemoteRepo( RemoteRepository repository )
+ public void addRemoteRepo( final RemoteRepository repository )
{
getRemoteRepos().addRemoterepo( repository );
}
- public void addRemoteRepos( RemoteRepositories repositories )
+ public void addRemoteRepos( final RemoteRepositories repositories )
{
getRemoteRepos().addRemoterepos( repositories );
}
- public void setRemoteReposRef( Reference ref )
+ public void setRemoteReposRef( final Reference ref )
{
- RemoteRepositories repos = new RemoteRepositories();
+ final RemoteRepositories repos = new RemoteRepositories();
repos.setProject( getProject() );
repos.setRefid( ref );
getRemoteRepos().addRemoterepos( repos );
diff --git a/src/main/java/org/apache/maven/resolver/internal/ant/types/Artifact.java b/src/main/java/org/apache/maven/resolver/internal/ant/types/Artifact.java
index 7a5d054..7527506 100644
--- a/src/main/java/org/apache/maven/resolver/internal/ant/types/Artifact.java
+++ b/src/main/java/org/apache/maven/resolver/internal/ant/types/Artifact.java
@@ -49,7 +49,7 @@ public class Artifact
return (Artifact) getCheckedRef();
}
- public void validate( Task task )
+ public void validate( final Task task )
{
if ( isReference() )
{
@@ -72,7 +72,7 @@ public class Artifact
}
}
- public void setRefid( Reference ref )
+ public void setRefid( final Reference ref )
{
if ( file != null || type != null || classifier != null )
{
@@ -90,15 +90,15 @@ public class Artifact
return file;
}
- public void setFile( File file )
+ public void setFile( final File file )
{
checkAttributesAllowed();
this.file = file;
if ( file != null && type == null )
{
- String name = file.getName();
- int period = name.lastIndexOf( '.' );
+ final String name = file.getName();
+ final int period = name.lastIndexOf( '.' );
if ( period >= 0 )
{
type = name.substring( period + 1 );
@@ -115,7 +115,7 @@ public class Artifact
return ( type != null ) ? type : "jar";
}
- public void setType( String type )
+ public void setType( final String type )
{
checkAttributesAllowed();
this.type = type;
@@ -130,22 +130,22 @@ public class Artifact
return ( classifier != null ) ? classifier : "";
}
- public void setClassifier( String classifier )
+ public void setClassifier( final String classifier )
{
checkAttributesAllowed();
this.classifier = classifier;
}
- public void setPomRef( Reference ref )
+ public void setPomRef( final Reference ref )
{
checkAttributesAllowed();
- Pom pom = new Pom();
+ final Pom pom = new Pom();
pom.setProject( getProject() );
pom.setRefid( ref );
this.pom = pom;
}
- public void addPom( Pom pom )
+ public void addPom( final Pom pom )
{
checkChildrenAllowed();
this.pom = pom;
@@ -174,7 +174,7 @@ public class Artifact
public String toString()
{
- String pomRepr = getPom() != null ? "(" + getPom().toString() + ":)" : "";
+ final String pomRepr = getPom() != null ? "(" + getPom().toString() + ":)" : "";
return String.format( pomRepr + "%s:%s", getType(), getClassifier() );
}