You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/24 09:45:55 UTC
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #12684: Add override argument interceptor
taojintianxia commented on a change in pull request #12684:
URL: https://github.com/apache/shardingsphere/pull/12684#discussion_r715472603
##########
File path: shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/bytebuddy/transformer/ShardingSphereTransformer.java
##########
@@ -138,15 +142,29 @@
return null;
}
if (classStaticMethodPoints.size() == 1) {
- return new ShardingSphereTransformationPoint<>(methodDescription, new ClassStaticMethodAroundInterceptor(pluginLoader.getOrCreateInstance(classStaticMethodPoints.get(0).getAdvice())));
+ if (classStaticMethodPoints.get(0).isOverrideArgs()) {
Review comment:
maybe 'guard clauses' will be better here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org