You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/14 07:03:17 UTC
[GitHub] [flink] horacehylee opened a new pull request #16821: [FLINK-23358] Refactor CoreOptions parent first patterns to List options
horacehylee opened a new pull request #16821:
URL: https://github.com/apache/flink/pull/16821
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
As stated in [FLINK-23358](https://issues.apache.org/jira/browse/FLINK-23358)
The following CoreOptions are all implemented as String options, but actually accept a List<String>, with some custom parsing thrown in:
```
ALWAYS_PARENT_FIRST_LOADER_PATTERNS
ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL
```
We should refactor them to proper List<String> options to reduce complexity.
This PR is to refactor these CoreOptions to List<String> and updated the corresponding tests.
## Brief change log
This PR is to refactor these CoreOptions to List<String> and updated the corresponding tests.
## Verifying this change
This change is already covered by existing tests:
- flink-core/src/test/java/org/apache/flink/configuration/CoreOptionsTest.java
- flink-core/src/test/java/org/apache/flink/configuration/ParentFirstPatternsTest.java
- - flink-core/src/main/java/org/apache/flink/core/classloading/SubmoduleClassLoader.java
- flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroKryoClassloadingTest.java
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): don't know
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-939244716
@xintongsong should be all good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-939413786
@xintongsong AZP all green (c7941dd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* Unknown: [CANCELED](TBD)
* 54a7d0d8f8dad4d7d22db13e405534f95fd32ce3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* 54a7d0d8f8dad4d7d22db13e405534f95fd32ce3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894)
* 538563426a8a8870b4bf26c020101ad69a3d86c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-939244581
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* Unknown: [CANCELED](TBD)
* 54a7d0d8f8dad4d7d22db13e405534f95fd32ce3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* 54a7d0d8f8dad4d7d22db13e405534f95fd32ce3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on a change in pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on a change in pull request #16821:
URL: https://github.com/apache/flink/pull/16821#discussion_r725431805
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -94,24 +101,39 @@
* </ul>
*/
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
- public static final ConfigOption<String> ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("classloader.parent-first-patterns.default")
- .defaultValue(
- "java.;scala.;org.apache.flink.;com.esotericsoftware.kryo;org.apache.hadoop.;javax.annotation.;org.xml;javax.xml;org.apache.xerces;org.w3c;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .stringType()
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.",
+ "scala.",
+ "org.apache.flink.",
+ "com.esotericsoftware.kryo",
+ "org.apache.hadoop.",
+ "javax.annotation.",
+ "org.xml",
+ "javax.xml",
+ "org.apache.xerces",
+ "org.w3c"),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDeprecatedKeys("classloader.parent-first-patterns")
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
Review comment:
Sure, updated the description accordingly.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -127,9 +149,13 @@
+ "thrown while trying to load a user code class.");
public static String[] getParentFirstLoaderPatterns(Configuration config) {
- String base = config.getString(ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
- String append = config.getString(ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
- return parseParentFirstLoaderPatterns(base, append);
+ List<String> base =
+ ConfigUtils.decodeListFromConfig(
+ config, ALWAYS_PARENT_FIRST_LOADER_PATTERNS, String::new);
+ List<String> append =
+ ConfigUtils.decodeListFromConfig(
+ config, ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL, String::new);
Review comment:
Updated
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
- .defaultValue(
- "java.;org.apache.flink.;javax.annotation.;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.", "org.apache.flink.", "javax.annotation."),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
Review comment:
Sure, updated the description accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
}, {
"hash" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926",
"triggerID" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* c7941dda940e9593b6c9c68baac3ede726485d3e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
}, {
"hash" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926",
"triggerID" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* c7941dda940e9593b6c9c68baac3ede726485d3e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on a change in pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on a change in pull request #16821:
URL: https://github.com/apache/flink/pull/16821#discussion_r725431848
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -94,24 +101,39 @@
* </ul>
*/
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
- public static final ConfigOption<String> ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("classloader.parent-first-patterns.default")
- .defaultValue(
- "java.;scala.;org.apache.flink.;com.esotericsoftware.kryo;org.apache.hadoop.;javax.annotation.;org.xml;javax.xml;org.apache.xerces;org.w3c;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .stringType()
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.",
+ "scala.",
+ "org.apache.flink.",
+ "com.esotericsoftware.kryo",
+ "org.apache.hadoop.",
+ "javax.annotation.",
+ "org.xml",
+ "javax.xml",
+ "org.apache.xerces",
+ "org.w3c"),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDeprecatedKeys("classloader.parent-first-patterns")
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
+ " resolved through the parent ClassLoader first. A pattern is a simple prefix that is checked against"
+ " the fully qualified class name. This setting should generally not be modified. To add another pattern we"
+ " recommend to use \"classloader.parent-first-patterns.additional\" instead.");
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
- public static final ConfigOption<String> ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+ public static final ConfigOption<List<String>> ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
ConfigOptions.key("classloader.parent-first-patterns.additional")
- .defaultValue("")
+ .stringType()
+ .asList()
+ .noDefaultValue()
Review comment:
Good catch. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
}, {
"hash" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926",
"triggerID" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* 538563426a8a8870b4bf26c020101ad69a3d86c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921)
* c7941dda940e9593b6c9c68baac3ede726485d3e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-939413786
@xintongsong AZP all green now (c7941dd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d243d7d843ca55c80d85ab48f12236203d86113 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* Unknown: [CANCELED](TBD)
* 30735755524707e1a408a29fc59404479b7ac5c3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888)
* 54a7d0d8f8dad4d7d22db13e405534f95fd32ce3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* Unknown: [CANCELED](TBD)
* 30735755524707e1a408a29fc59404479b7ac5c3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on a change in pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on a change in pull request #16821:
URL: https://github.com/apache/flink/pull/16821#discussion_r725431881
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -36,8 +38,13 @@
public class CoreOptions {
@Internal
- public static final String PARENT_FIRST_LOGGING_PATTERNS =
- "org.slf4j;org.apache.log4j;org.apache.logging;org.apache.commons.logging;ch.qos.logback";
+ public static final List<String> PARENT_FIRST_LOGGING_PATTERNS =
+ Arrays.asList(
+ "org.slf4j",
+ "org.apache.log4j",
+ "org.apache.logging",
+ "org.apache.commons.logging",
+ "ch.qos.logback");
Review comment:
Yes it will be much nicer with `String[]`
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
- .defaultValue(
- "java.;org.apache.flink.;javax.annotation.;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.", "org.apache.flink.", "javax.annotation."),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
+ " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
+ " against the fully qualified class name. This setting should generally not be modified. To add another "
+ " pattern we recommend to use \"plugin.classloader.parent-first-patterns.additional\" instead.");
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
- ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
- .stringType()
- .defaultValue("")
- .withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
- + " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
- + " against the fully qualified class name. These patterns are appended to \""
- + PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
- + "\".");
+ public static final ConfigOption<List<String>>
+ PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+ ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
+ .stringType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "A list of patterns that specifies which classes should always be"
Review comment:
Sure, updated the description accordingly.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
- .defaultValue(
- "java.;org.apache.flink.;javax.annotation.;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.", "org.apache.flink.", "javax.annotation."),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
+ " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
+ " against the fully qualified class name. This setting should generally not be modified. To add another "
+ " pattern we recommend to use \"plugin.classloader.parent-first-patterns.additional\" instead.");
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
- ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
- .stringType()
- .defaultValue("")
- .withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
- + " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
- + " against the fully qualified class name. These patterns are appended to \""
- + PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
- + "\".");
+ public static final ConfigOption<List<String>>
+ PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+ ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
+ .stringType()
+ .asList()
+ .noDefaultValue()
Review comment:
Updated
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
- .defaultValue(
- "java.;org.apache.flink.;javax.annotation.;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.", "org.apache.flink.", "javax.annotation."),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
+ " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
+ " against the fully qualified class name. This setting should generally not be modified. To add another "
+ " pattern we recommend to use \"plugin.classloader.parent-first-patterns.additional\" instead.");
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
- ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
- .stringType()
- .defaultValue("")
- .withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
- + " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
- + " against the fully qualified class name. These patterns are appended to \""
- + PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
- + "\".");
+ public static final ConfigOption<List<String>>
+ PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+ ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
+ .stringType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "A list of patterns that specifies which classes should always be"
+ + " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
+ + " against the fully qualified class name. These patterns are appended to \""
+ + PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
+ + "\".");
public static String[] getPluginParentFirstLoaderPatterns(Configuration config) {
- String base = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
- String append = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
- return parseParentFirstLoaderPatterns(base, append);
+ List<String> base =
+ ConfigUtils.decodeListFromConfig(
+ config, PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS, String::new);
+ List<String> append =
+ ConfigUtils.decodeListFromConfig(
+ config, PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL, String::new);
Review comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* 538563426a8a8870b4bf26c020101ad69a3d86c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d243d7d843ca55c80d85ab48f12236203d86113 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-939226259
@xintongsong Updated the code changes, can help to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #16821:
URL: https://github.com/apache/flink/pull/16821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* 54a7d0d8f8dad4d7d22db13e405534f95fd32ce3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894)
* 538563426a8a8870b4bf26c020101ad69a3d86c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d243d7d843ca55c80d85ab48f12236203d86113 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d243d7d843ca55c80d85ab48f12236203d86113 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898851554
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0d243d7d843ca55c80d85ab48f12236203d86113 (Sat Aug 14 07:11:06 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-23358).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d243d7d843ca55c80d85ab48f12236203d86113 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* 54a7d0d8f8dad4d7d22db13e405534f95fd32ce3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894)
* 538563426a8a8870b4bf26c020101ad69a3d86c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d243d7d843ca55c80d85ab48f12236203d86113 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* Unknown: [CANCELED](TBD)
* 30735755524707e1a408a29fc59404479b7ac5c3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d243d7d843ca55c80d85ab48f12236203d86113 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173)
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* 54a7d0d8f8dad4d7d22db13e405534f95fd32ce3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
}, {
"hash" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926",
"triggerID" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7941dda940e9593b6c9c68baac3ede726485d3e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24926)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898883515
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d243d7d843ca55c80d85ab48f12236203d86113 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #16821:
URL: https://github.com/apache/flink/pull/16821#discussion_r724660924
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -127,9 +149,13 @@
+ "thrown while trying to load a user code class.");
public static String[] getParentFirstLoaderPatterns(Configuration config) {
- String base = config.getString(ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
- String append = config.getString(ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
- return parseParentFirstLoaderPatterns(base, append);
+ List<String> base =
+ ConfigUtils.decodeListFromConfig(
+ config, ALWAYS_PARENT_FIRST_LOADER_PATTERNS, String::new);
+ List<String> append =
+ ConfigUtils.decodeListFromConfig(
+ config, ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL, String::new);
Review comment:
```suggestion
List<String> base = config.get(ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
List<String> append = config.get(ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
```
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -94,24 +101,39 @@
* </ul>
*/
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
- public static final ConfigOption<String> ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("classloader.parent-first-patterns.default")
- .defaultValue(
- "java.;scala.;org.apache.flink.;com.esotericsoftware.kryo;org.apache.hadoop.;javax.annotation.;org.xml;javax.xml;org.apache.xerces;org.w3c;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .stringType()
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.",
+ "scala.",
+ "org.apache.flink.",
+ "com.esotericsoftware.kryo",
+ "org.apache.hadoop.",
+ "javax.annotation.",
+ "org.xml",
+ "javax.xml",
+ "org.apache.xerces",
+ "org.w3c"),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDeprecatedKeys("classloader.parent-first-patterns")
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
Review comment:
No need to remove `(semicolon-separated)`. It's a good hint for users on how to format a list type config option.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -36,8 +38,13 @@
public class CoreOptions {
@Internal
- public static final String PARENT_FIRST_LOGGING_PATTERNS =
- "org.slf4j;org.apache.log4j;org.apache.logging;org.apache.commons.logging;ch.qos.logback";
+ public static final List<String> PARENT_FIRST_LOGGING_PATTERNS =
+ Arrays.asList(
+ "org.slf4j",
+ "org.apache.log4j",
+ "org.apache.logging",
+ "org.apache.commons.logging",
+ "ch.qos.logback");
Review comment:
You can save a lot of conversions between list and array by making this a `String[]`.
Because `defaultValues()` only takes arrays. The only thing you need would be `ArrayUtils.concat()` for merging two arrays. `mergeListsToArray` will not be necessary.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
- .defaultValue(
- "java.;org.apache.flink.;javax.annotation.;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.", "org.apache.flink.", "javax.annotation."),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
+ " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
+ " against the fully qualified class name. This setting should generally not be modified. To add another "
+ " pattern we recommend to use \"plugin.classloader.parent-first-patterns.additional\" instead.");
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
- ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
- .stringType()
- .defaultValue("")
- .withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
- + " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
- + " against the fully qualified class name. These patterns are appended to \""
- + PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
- + "\".");
+ public static final ConfigOption<List<String>>
+ PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+ ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
+ .stringType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "A list of patterns that specifies which classes should always be"
Review comment:
Same here for `(semicolon-separated)`.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
- .defaultValue(
- "java.;org.apache.flink.;javax.annotation.;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.", "org.apache.flink.", "javax.annotation."),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
+ " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
+ " against the fully qualified class name. This setting should generally not be modified. To add another "
+ " pattern we recommend to use \"plugin.classloader.parent-first-patterns.additional\" instead.");
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
- ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
- .stringType()
- .defaultValue("")
- .withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
- + " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
- + " against the fully qualified class name. These patterns are appended to \""
- + PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
- + "\".");
+ public static final ConfigOption<List<String>>
+ PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+ ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
+ .stringType()
+ .asList()
+ .noDefaultValue()
Review comment:
Same here for default values.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
- .defaultValue(
- "java.;org.apache.flink.;javax.annotation.;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.", "org.apache.flink.", "javax.annotation."),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
+ " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
+ " against the fully qualified class name. This setting should generally not be modified. To add another "
+ " pattern we recommend to use \"plugin.classloader.parent-first-patterns.additional\" instead.");
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
- ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
- .stringType()
- .defaultValue("")
- .withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
- + " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
- + " against the fully qualified class name. These patterns are appended to \""
- + PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
- + "\".");
+ public static final ConfigOption<List<String>>
+ PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+ ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
+ .stringType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "A list of patterns that specifies which classes should always be"
+ + " resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked "
+ + " against the fully qualified class name. These patterns are appended to \""
+ + PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
+ + "\".");
public static String[] getPluginParentFirstLoaderPatterns(Configuration config) {
- String base = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
- String append = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
- return parseParentFirstLoaderPatterns(base, append);
+ List<String> base =
+ ConfigUtils.decodeListFromConfig(
+ config, PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS, String::new);
+ List<String> append =
+ ConfigUtils.decodeListFromConfig(
+ config, PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL, String::new);
Review comment:
```suggestion
List<String> base = config.get(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
List<String> append = config.get(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
```
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate unintended side-effects of this young feature.")
- public static final ConfigOption<String> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
- .defaultValue(
- "java.;org.apache.flink.;javax.annotation.;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.", "org.apache.flink.", "javax.annotation."),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
Review comment:
Same here for `(semicolon-separated)`.
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -94,24 +101,39 @@
* </ul>
*/
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
- public static final ConfigOption<String> ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+ public static final ConfigOption<List<String>> ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("classloader.parent-first-patterns.default")
- .defaultValue(
- "java.;scala.;org.apache.flink.;com.esotericsoftware.kryo;org.apache.hadoop.;javax.annotation.;org.xml;javax.xml;org.apache.xerces;org.w3c;"
- + PARENT_FIRST_LOGGING_PATTERNS)
+ .stringType()
+ .asList()
+ .defaultValues(
+ mergeListsToArray(
+ Arrays.asList(
+ "java.",
+ "scala.",
+ "org.apache.flink.",
+ "com.esotericsoftware.kryo",
+ "org.apache.hadoop.",
+ "javax.annotation.",
+ "org.xml",
+ "javax.xml",
+ "org.apache.xerces",
+ "org.w3c"),
+ PARENT_FIRST_LOGGING_PATTERNS))
.withDeprecatedKeys("classloader.parent-first-patterns")
.withDescription(
- "A (semicolon-separated) list of patterns that specifies which classes should always be"
+ "A list of patterns that specifies which classes should always be"
+ " resolved through the parent ClassLoader first. A pattern is a simple prefix that is checked against"
+ " the fully qualified class name. This setting should generally not be modified. To add another pattern we"
+ " recommend to use \"classloader.parent-first-patterns.additional\" instead.");
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
- public static final ConfigOption<String> ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+ public static final ConfigOption<List<String>> ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
ConfigOptions.key("classloader.parent-first-patterns.additional")
- .defaultValue("")
+ .stringType()
+ .asList()
+ .noDefaultValue()
Review comment:
```suggestion
.defaultValues()
```
Default value should be an empty list. Otherwise, it returns `null` for this option when it's not specified, which can easily lead to NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"triggerType" : "PUSH"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "0d243d7d843ca55c80d85ab48f12236203d86113",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173",
"triggerID" : "898883515",
"triggerType" : "MANUAL"
}, {
"hash" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860f7acaf90b23fbff802792749ef1bd0479a414",
"triggerType" : "PUSH"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "30735755524707e1a408a29fc59404479b7ac5c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888",
"triggerID" : "30735755524707e1a408a29fc59404479b7ac5c3",
"triggerType" : "PUSH"
}, {
"hash" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24894",
"triggerID" : "54a7d0d8f8dad4d7d22db13e405534f95fd32ce3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939226572",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939244581",
"triggerType" : "MANUAL"
}, {
"hash" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921",
"triggerID" : "538563426a8a8870b4bf26c020101ad69a3d86c7",
"triggerType" : "PUSH"
}, {
"hash" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7941dda940e9593b6c9c68baac3ede726485d3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN
* 538563426a8a8870b4bf26c020101ad69a3d86c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24921)
* c7941dda940e9593b6c9c68baac3ede726485d3e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] horacehylee commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
Posted by GitBox <gi...@apache.org>.
horacehylee commented on pull request #16821:
URL: https://github.com/apache/flink/pull/16821#issuecomment-939226572
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org