[jira] [Comment Edited] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores

["Mingliang Liu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973649#comment-16973649 ] 

Mingliang Liu edited comment on HBASE-23283 at 11/15/19 12:58 AM:
------------------------------------------------------------------

[~busbey] I  don't have commit access so could you kindly do the favor and commit this? Thanks!


was (Author: liuml07):
[[~busbey]I  don't have commit access so could you kindly do the favor...Thanks!

> Provide clear and consistent logging about the period of enabled chores
> -----------------------------------------------------------------------
>
>                 Key: HBASE-23283
>                 URL: https://issues.apache.org/jira/browse/HBASE-23283
>             Project: HBase
>          Issue Type: Improvement
>          Components: Operability
>    Affects Versions: 3.0.0, 2.3.0, 1.7.0
>            Reporter: Sean Busbey
>            Assignee: Mingliang Liu
>            Priority: Minor
>         Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores. Right now wether or not we get some information is up to particular Chore constructors and by and large we don't get any log messages when things can get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
>       if (chore.getPeriod() <= 0) {
>         LOG.info("The period is {} seconds, {} is disabled", chore.getPeriod(), chore.getName());
>         return false;
>       }
> {code}
> we should add an else clause that says it's enabled. It looks like we could then just call chore.toString to get the proper details about the chore and its period.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)