You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sh...@apache.org on 2014/06/27 14:14:57 UTC

svn commit: r1606046 - in /lucene/dev/trunk/solr: CHANGES.txt core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java core/src/test/org/apache/solr/cloud/TestCollectionAPI.java

Author: shalin
Date: Fri Jun 27 12:14:57 2014
New Revision: 1606046

URL: http://svn.apache.org/r1606046
Log:
SOLR-6044: The 'clusterstatus' API should return live_nodes as well

Modified:
    lucene/dev/trunk/solr/CHANGES.txt
    lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java
    lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/TestCollectionAPI.java

Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1606046&r1=1606045&r2=1606046&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Fri Jun 27 12:14:57 2014
@@ -96,6 +96,8 @@ New Features
 
 * SOLR-6069: The 'clusterstatus' API should return 'roles' information. (shalin)
 
+* SOLR-6044: The 'clusterstatus' API should return live_nodes as well. (shalin)
+
 Bug Fixes
 ----------------------
 

Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java?rev=1606046&r1=1606045&r2=1606046&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java Fri Jun 27 12:14:57 2014
@@ -693,7 +693,7 @@ public class OverseerCollectionProcessor
     }
 
     Map roles = null;
-    if(zkStateReader.getZkClient().exists(ZkStateReader.ROLES, true)){
+    if (zkStateReader.getZkClient().exists(ZkStateReader.ROLES, true)) {
       roles = (Map) ZkStateReader.fromJSON(zkStateReader.getZkClient().getData(ZkStateReader.ROLES, null, null, true));
     }
 
@@ -763,6 +763,10 @@ public class OverseerCollectionProcessor
       clusterStatus.add("roles", roles);
     }
 
+    // add live_nodes
+    List<String> liveNodes = zkStateReader.getZkClient().getChildren(ZkStateReader.LIVE_NODES_ZKNODE, null, true);
+    clusterStatus.add("live_nodes", liveNodes);
+
     results.add("cluster", clusterStatus);
   }
 

Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/TestCollectionAPI.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/TestCollectionAPI.java?rev=1606046&r1=1606045&r2=1606046&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/TestCollectionAPI.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/TestCollectionAPI.java Fri Jun 27 12:14:57 2014
@@ -146,6 +146,9 @@ public class TestCollectionAPI extends A
       assertNotNull(collections.get(COLLECTION_NAME1));
       assertEquals(4, collections.size());
 
+      List<String> liveNodes = (List<String>) cluster.get("live_nodes");
+      assertNotNull("Live nodes should not be null", liveNodes);
+      assertFalse(liveNodes.isEmpty());
     } finally {
       //remove collections
       client.shutdown();