You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/17 17:08:01 UTC
[GitHub] [airflow] Bowrna opened a new pull request #22344: ci prepare-build-cache
Bowrna opened a new pull request #22344:
URL: https://github.com/apache/airflow/pull/22344
closes : #21102
related: #21102
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#issuecomment-1085480799
> > > @potiuk i want to know how we can pass the `CI` flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?
> > > https://github.com/apache/airflow/blob/c58b5e583bcad83048fdee72bc9ddf6c3a7b4229/scripts/ci/libraries/_build_images.sh#L454-L463
> >
> >
> > @potiuk Please share your view on this when you get time.
>
> Same as in Bash. Just add the `PIP_PROGRESS_BAR==off` if `CI` is set to `true`. There is no need to pass it further. But in order to do it nicely you can add `--ci` parameter with CI `envvar` via click.
@potiuk Added this support too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22344:
URL: https://github.com/apache/airflow/pull/22344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#issuecomment-1084540144
> > @potiuk i want to know how we can pass the `CI` flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?
> > https://github.com/apache/airflow/blob/c58b5e583bcad83048fdee72bc9ddf6c3a7b4229/scripts/ci/libraries/_build_images.sh#L454-L463
>
> @potiuk Please share your view on this when you get time.
Same as in Bash. Just add the ``PIP_PROGRESS_BAR==off`` if `CI` is set to `true`. There is no need to pass it further. But in order to do it nicely you can add ``--ci`` parameter with CI `envvar` via click.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#issuecomment-1085388095
@potiuk Added fix for flag `upgrade_to_newer_dependencies` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#issuecomment-1084010502
> @potiuk i want to know how we can pass the `CI` flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?
>
> https://github.com/apache/airflow/blob/c58b5e583bcad83048fdee72bc9ddf6c3a7b4229/scripts/ci/libraries/_build_images.sh#L454-L463
@potiuk Please share your view on this when you get time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#discussion_r839408446
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -302,7 +303,8 @@ def build_ci_image(
build_cache: Optional[str],
platform: Optional[str],
debian_version: Optional[str],
- upgrade_to_newer_dependencies: Optional[str],
+ upgrade_to_newer_dependencies: bool,
Review comment:
That was the fix I made here -> https://github.com/apache/airflow/pull/22597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#discussion_r839454707
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -302,7 +303,8 @@ def build_ci_image(
build_cache: Optional[str],
platform: Optional[str],
debian_version: Optional[str],
- upgrade_to_newer_dependencies: Optional[str],
+ upgrade_to_newer_dependencies: bool,
Review comment:
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#discussion_r839874932
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -302,7 +303,8 @@ def build_ci_image(
build_cache: Optional[str],
platform: Optional[str],
debian_version: Optional[str],
- upgrade_to_newer_dependencies: Optional[str],
+ upgrade_to_newer_dependencies: bool,
Review comment:
I added more fixes on the parameter in #22649 :). You will need to rebase and resolve conflicts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on a change in pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
Bowrna commented on a change in pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#discussion_r839450326
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -302,7 +303,8 @@ def build_ci_image(
build_cache: Optional[str],
platform: Optional[str],
debian_version: Optional[str],
- upgrade_to_newer_dependencies: Optional[str],
+ upgrade_to_newer_dependencies: bool,
Review comment:
@potiuk Is it Optional[str] for prod image too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#discussion_r839405935
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -302,7 +303,8 @@ def build_ci_image(
build_cache: Optional[str],
platform: Optional[str],
debian_version: Optional[str],
- upgrade_to_newer_dependencies: Optional[str],
+ upgrade_to_newer_dependencies: bool,
Review comment:
```suggestion
upgrade_to_newer_dependencies: bool,
```
This should be Optional[str] actually :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#issuecomment-1082689212
@potiuk
`--cache:max should be added also in the CI image (because it is multi-segment image now)`
https://github.com/apache/airflow/pull/22492#issuecomment-1076650709
I will add this as part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#issuecomment-1084540144
> > @potiuk i want to know how we can pass the `CI` flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?
> > https://github.com/apache/airflow/blob/c58b5e583bcad83048fdee72bc9ddf6c3a7b4229/scripts/ci/libraries/_build_images.sh#L454-L463
>
> @potiuk Please share your view on this when you get time.
Same as in Bash. Just add the ``PIP_PROGRESS_BAR`` if CI is set. There is no need to pass it further. But in order to do it nicely you can add ``--ci`` parameter with CI `envvar` via click.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#issuecomment-1082937700
@potiuk i want to know how we can pass the `CI` flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?
https://github.com/apache/airflow/blob/c58b5e583bcad83048fdee72bc9ddf6c3a7b4229/scripts/ci/libraries/_build_images.sh#L454-L463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #22344: ci prepare-build-cache
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #22344:
URL: https://github.com/apache/airflow/pull/22344#issuecomment-1084010324
@potiuk I made changes specified in this https://github.com/apache/airflow/pull/22618
Please verify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org