You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "limowang (via GitHub)" <gi...@apache.org> on 2025/09/19 06:11:05 UTC

[PR] fix(scripts): Fix the issue where running pegasus_manual_compact.sh on small tables sometimes hangs [incubator-pegasus]

limowang opened a new pull request, #2298:
URL: https://github.com/apache/incubator-pegasus/pull/2298

   [#2297](https://github.com/apache/incubator-pegasus/issues/2297)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] fix(scripts): Fix the issue where running pegasus_manual_compact.sh on small tables sometimes hangs [incubator-pegasus]

Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on PR #2298:
URL: https://github.com/apache/incubator-pegasus/pull/2298#issuecomment-3310769998

   This pull request makes a minor adjustment to the `wait_manual_compact()` function in `admin_tools/pegasus_manual_compact.sh`, specifically changing the timestamp format used when displaying the earliest finish time for a compact operation.
   
   - Changed the output format of `earliest_finish_time_ms` to exclude milliseconds when displaying the compact progress timestamp.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] fix(scripts): Fix the issue where running pegasus_manual_compact.sh on small tables sometimes hangs [incubator-pegasus]

Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #2298:
URL: https://github.com/apache/incubator-pegasus/pull/2298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] fix(scripts): Fix the issue where running pegasus_manual_compact.sh on small tables sometimes hangs [incubator-pegasus]

Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on PR #2298:
URL: https://github.com/apache/incubator-pegasus/pull/2298#issuecomment-3310949103

   The root cause is still comparing timestamps as strings, right? Would it be safer to convert the strings to integers for comparison during the later refactoring?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] fix(scripts): Fix the issue where running pegasus_manual_compact.sh on small tables sometimes hangs [incubator-pegasus]

Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on PR #2298:
URL: https://github.com/apache/incubator-pegasus/pull/2298#issuecomment-3310775028

   > This pull request makes a minor adjustment to the `wait_manual_compact()` function in `admin_tools/pegasus_manual_compact.sh`, specifically changing the timestamp format used when displaying the earliest finish time for a compact operation.
   > 
   > * Changed the output format of `earliest_finish_time_ms` to exclude milliseconds when displaying the compact progress timestamp.
   
   Sumaried by Copilot
   <img width="952" height="258" alt="image" src="https://github.com/user-attachments/assets/e82562e5-b9de-4cad-8daf-1bd7a15ab7bd" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org