You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gabrielenizzoli <gi...@git.apache.org> on 2016/02/01 22:06:39 UTC

[GitHub] spark pull request: java mapwithstate, broken java mapping

GitHub user gabrielenizzoli opened a pull request:

    https://github.com/apache/spark/pull/11007

    java mapwithstate, broken java mapping

    java mapwithstate with Function3 has wrong conversion of java Optional to scala Option, now code uses same conversion used in the mapwithstate call that uses Function4 as an input

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gabrielenizzoli/spark branch-1.6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11007
    
----
commit 78c0323f90d1f31796732229aad84ab1f5f74332
Author: Gabriele Nizzoli <ma...@nizzoli.net>
Date:   2016-02-01T21:03:57Z

    java mapwithstate broken java mapping
    
    java mapwithstate with Function3 has wrong conversion of java Optional to scala Option

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: java mapwithstate, broken java mapping

Posted by holdenk <gi...@git.apache.org>.

Github user holdenk commented on the pull request:

    https://github.com/apache/spark/pull/11007#issuecomment-178206958
  
    Hi @gabrielenizzoli - generally Spark require's that there is a JIRA associated the proposed change as well as having it mentioned in the pull request title. This is also just merging against the 1.6 branch but generally most changes are applied to master and then explicitly back ported (looking in master it seems to have changed as part of the migration away from having guava in the public API to `Optional.ofNullable`). The guide at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark can be quite useful for structuring your pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11007#issuecomment-178420557
  
    **[Test build #50544 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50544/consoleFull)** for PR 11007 at commit [`78c0323`](https://github.com/apache/spark/commit/78c0323f90d1f31796732229aad84ab1f5f74332).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11007#issuecomment-178397680
  
    **[Test build #50544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50544/consoleFull)** for PR 11007 at commit [`78c0323`](https://github.com/apache/spark/commit/78c0323f90d1f31796732229aad84ab1f5f74332).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

Posted by zsxwing <gi...@git.apache.org>.

Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/11007#issuecomment-178759342
  
    @gabrielenizzoli I have merged this PR to branch 1.6. Could you open a new PR to fix the master branch and close this one? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

Posted by zsxwing <gi...@git.apache.org>.

Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/11007#issuecomment-178757483
  
    Merging to master and 1.6. Thanks @gabrielenizzoli


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11007#issuecomment-178379160
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11007#issuecomment-178717173
  
    **[Test build #50571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50571/consoleFull)** for PR 11007 at commit [`78c0323`](https://github.com/apache/spark/commit/78c0323f90d1f31796732229aad84ab1f5f74332).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org