You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Jeff Mesnil (JIRA)" <ji...@apache.org> on 2011/07/06 08:54:16 UTC

[jira] [Created] (AVRO-851) Unicode issue in JSON encoding from Java

Unicode issue in JSON encoding from Java
----------------------------------------

                 Key: AVRO-851
                 URL: https://issues.apache.org/jira/browse/AVRO-851
             Project: Avro
          Issue Type: Bug
          Components: java
    Affects Versions: 1.5.1
            Reporter: Jeff Mesnil


There is an issue in Avro's java code when encoding a GenericData as JSON in GenericData#writeEscapedString().
In the default clause, it must be the hexadecimal value of the character that must be written and not the string itself, otherwise the built JSON string is not valid. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-851) Unicode issue in JSON encoding from Java

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-851:
------------------------------

    Fix Version/s: 1.6.0
         Assignee: Jeff Mesnil

> Unicode issue in JSON encoding from Java
> ----------------------------------------
>
>                 Key: AVRO-851
>                 URL: https://issues.apache.org/jira/browse/AVRO-851
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.5.1
>            Reporter: Jeff Mesnil
>            Assignee: Jeff Mesnil
>             Fix For: 1.6.0
>
>         Attachments: AVRO-851.patch
>
>
> There is an issue in Avro's java code when encoding a GenericData as JSON in GenericData#writeEscapedString().
> In the default clause, it must be the hexadecimal value of the character that must be written and not the string itself, otherwise the built JSON string is not valid. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (AVRO-851) Unicode issue in JSON encoding from Java

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting resolved AVRO-851.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.7.2

I committed this.

It took over a year to get this committed!  I'm not sure how it slipped through the cracks for so long.  Mea culpa.  My apologies.
                
> Unicode issue in JSON encoding from Java
> ----------------------------------------
>
>                 Key: AVRO-851
>                 URL: https://issues.apache.org/jira/browse/AVRO-851
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.5.1
>            Reporter: Jeff Mesnil
>            Assignee: Jeff Mesnil
>             Fix For: 1.7.2
>
>         Attachments: AVRO-851.patch
>
>
> There is an issue in Avro's java code when encoding a GenericData as JSON in GenericData#writeEscapedString().
> In the default clause, it must be the hexadecimal value of the character that must be written and not the string itself, otherwise the built JSON string is not valid. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (AVRO-851) Unicode issue in JSON encoding from Java

Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060684#comment-13060684 ] 

Scott Carey edited comment on AVRO-851 at 7/6/11 4:56 PM:
----------------------------------------------------------

+1

Test reproduces error and patch fixes it.

      was (Author: scott_carey):
    +!  

Test reproduces error and patch fixes it.
  
> Unicode issue in JSON encoding from Java
> ----------------------------------------
>
>                 Key: AVRO-851
>                 URL: https://issues.apache.org/jira/browse/AVRO-851
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.5.1
>            Reporter: Jeff Mesnil
>         Attachments: AVRO-851.patch
>
>
> There is an issue in Avro's java code when encoding a GenericData as JSON in GenericData#writeEscapedString().
> In the default clause, it must be the hexadecimal value of the character that must be written and not the string itself, otherwise the built JSON string is not valid. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (AVRO-851) Unicode issue in JSON encoding from Java

Posted by "Jeff Mesnil (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060325#comment-13060325 ] 

Jeff Mesnil commented on AVRO-851:
----------------------------------

I've attached a patch that is ready for code review

> Unicode issue in JSON encoding from Java
> ----------------------------------------
>
>                 Key: AVRO-851
>                 URL: https://issues.apache.org/jira/browse/AVRO-851
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.5.1
>            Reporter: Jeff Mesnil
>         Attachments: AVRO-851.patch
>
>
> There is an issue in Avro's java code when encoding a GenericData as JSON in GenericData#writeEscapedString().
> In the default clause, it must be the hexadecimal value of the character that must be written and not the string itself, otherwise the built JSON string is not valid. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (AVRO-851) Unicode issue in JSON encoding from Java

Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060684#comment-13060684 ] 

Scott Carey commented on AVRO-851:
----------------------------------

+!  

Test reproduces error and patch fixes it.

> Unicode issue in JSON encoding from Java
> ----------------------------------------
>
>                 Key: AVRO-851
>                 URL: https://issues.apache.org/jira/browse/AVRO-851
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.5.1
>            Reporter: Jeff Mesnil
>         Attachments: AVRO-851.patch
>
>
> There is an issue in Avro's java code when encoding a GenericData as JSON in GenericData#writeEscapedString().
> In the default clause, it must be the hexadecimal value of the character that must be written and not the string itself, otherwise the built JSON string is not valid. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-851) Unicode issue in JSON encoding from Java

Posted by "Jeff Mesnil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Mesnil updated AVRO-851:
-----------------------------

    Attachment: AVRO-851.patch

* fix unicode issue in GenericData#writeEscapedString()
* add unicode char in TestGenericData#testToStringIsJson() to check that the character is properly encoded in JSON

> Unicode issue in JSON encoding from Java
> ----------------------------------------
>
>                 Key: AVRO-851
>                 URL: https://issues.apache.org/jira/browse/AVRO-851
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.5.1
>            Reporter: Jeff Mesnil
>         Attachments: AVRO-851.patch
>
>
> There is an issue in Avro's java code when encoding a GenericData as JSON in GenericData#writeEscapedString().
> In the default clause, it must be the hexadecimal value of the character that must be written and not the string itself, otherwise the built JSON string is not valid. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira