[GitHub] [superset] betodealmeida commented on a diff in pull request #23175: fix(ssh-tunnel): add password to `from_private_key` function

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #23175:
URL: https://github.com/apache/superset/pull/23175#discussion_r1117729273


##########
superset/extensions/ssh.py:
##########
@@ -62,9 +62,10 @@ def create_tunnel(
             params["ssh_password"] = ssh_tunnel.password
         elif ssh_tunnel.private_key:
             private_key_file = StringIO(ssh_tunnel.private_key)
-            private_key = RSAKey.from_private_key(private_key_file)
+            private_key = RSAKey.from_private_key(
+                private_key_file, ssh_tunnel.private_key_password
+            )
             params["ssh_pkey"] = private_key
-            params["ssh_private_key_password"] = ssh_tunnel.private_key_password

Review Comment:
   This is no longer needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org