You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/03/20 16:56:49 UTC
[GitHub] qpid-dispatch pull request #270: DISPATCH-933 - Created new RouterStats enti...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/270
DISPATCH-933 - Created new RouterStats entity. Moved some attributes …
…from Router entity to RouterStats. Router entity is not handled by the Python management agent and the RouterStats entity is handled by the C management agent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-933-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #270
----
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #270: DISPATCH-933 - Created new RouterStats enti...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/270
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #270: DISPATCH-933 - Created new RouterStats enti...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/270#discussion_r176223364
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,107 @@
"description": "Time in seconds after which link state is declared stale if no RA is received.",
"create": true
},
- "addrCount": {
- "type": "integer",
- "description":"Number of addresses known to the router.",
- "graph": true
- },
- "linkCount": {
+ "workerThreads": {
"type": "integer",
- "description":"Number of links attached to the router node.",
- "graph": true
+ "default": 4,
+ "description": "The number of threads that will be created to process message traffic and other application work (timers, non-amqp file descriptors, etc.) .",
+ "create": true
},
- "nodeCount": {
- "type": "integer",
- "description":"Number of known peer router nodes.",
- "graph": true
+ "debugDump": {
+ "type": "path",
+ "description": "The absolute path to the location for the debug dump file. The router writes debug-level information to this file if the logger is not available.",
+ "create": true
},
- "linkRouteCount": {
- "type": "integer",
- "description":"Number of link routes attached to the router node.",
- "graph": true
+ "saslConfigPath": {
+ "type": "path",
+ "description": "Absolute path to the SASL configuration file.",
+ "required": false,
+ "create": true
},
- "autoLinkCount": {
- "type": "integer",
- "description":"Number of auto links attached to the router node.",
- "graph": true
+ "saslConfigName": {
+ "type": "string",
+ "description": "Name of the SASL configuration. This string + '.conf' is the name of the configuration file.",
+ "default": "qdrouterd",
+ "required": false,
+ "create": true
},
- "connectionCount": {
- "type": "integer",
- "description":"Number of open connections to the router node.",
- "graph": true
+ "allowResumableLinkRoute": {
+ "type": "boolean",
+ "description": "Whether links can be routed where timeout is non-zero or expiry-policy is not link-detach",
+ "create": true,
+ "required": false,
+ "default": true
+ },
+ "allowUnsettledMulticast": {
+ "type": "boolean",
+ "description": "If true, allow senders to send unsettled deliveries to multicast addresses. These deliveries shall be settled by the ingress router. If false, unsettled deliveries to multicast addresses shall be rejected.",
+ "create": true,
+ "required": false,
+ "default": false
},
-
+ "defaultDistribution": {
+ "type": ["multicast", "closest", "balanced", "unavailable"],
+ "description": "Default forwarding treatment for any address without a specified treatment. multicast - one copy of each message delivered to all subscribers; closest - messages delivered to only the closest subscriber; balanced - messages delivered to one subscriber with load balanced across subscribers; unavailable - this address is unavailable, link attaches to an address of unavilable distribution will be rejected.",
+ "create": true,
+ "required": false,
+ "default": "balanced"
+ }
+ }
+ },
+
+ "routerStats": {
+ "description": "Overall router statistics.",
+ "extends": "operationalEntity",
+ "attributes": {
+ "id": {
+ "description":"Router's unique identity. The router will fail to start without id.",
+ "type": "string",
+ "required": false,
+ "create": true
+ },
+ "mode": {
--- End diff --
Good point. I will remove it
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #270: DISPATCH-933 - Created new RouterStats enti...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/270#discussion_r176214977
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,107 @@
"description": "Time in seconds after which link state is declared stale if no RA is received.",
"create": true
},
- "addrCount": {
- "type": "integer",
- "description":"Number of addresses known to the router.",
- "graph": true
- },
- "linkCount": {
+ "workerThreads": {
"type": "integer",
- "description":"Number of links attached to the router node.",
- "graph": true
+ "default": 4,
+ "description": "The number of threads that will be created to process message traffic and other application work (timers, non-amqp file descriptors, etc.) .",
+ "create": true
},
- "nodeCount": {
- "type": "integer",
- "description":"Number of known peer router nodes.",
- "graph": true
+ "debugDump": {
+ "type": "path",
+ "description": "The absolute path to the location for the debug dump file. The router writes debug-level information to this file if the logger is not available.",
+ "create": true
},
- "linkRouteCount": {
- "type": "integer",
- "description":"Number of link routes attached to the router node.",
- "graph": true
+ "saslConfigPath": {
+ "type": "path",
+ "description": "Absolute path to the SASL configuration file.",
+ "required": false,
+ "create": true
},
- "autoLinkCount": {
- "type": "integer",
- "description":"Number of auto links attached to the router node.",
- "graph": true
+ "saslConfigName": {
+ "type": "string",
+ "description": "Name of the SASL configuration. This string + '.conf' is the name of the configuration file.",
+ "default": "qdrouterd",
+ "required": false,
+ "create": true
},
- "connectionCount": {
- "type": "integer",
- "description":"Number of open connections to the router node.",
- "graph": true
+ "allowResumableLinkRoute": {
+ "type": "boolean",
+ "description": "Whether links can be routed where timeout is non-zero or expiry-policy is not link-detach",
+ "create": true,
+ "required": false,
+ "default": true
+ },
+ "allowUnsettledMulticast": {
+ "type": "boolean",
+ "description": "If true, allow senders to send unsettled deliveries to multicast addresses. These deliveries shall be settled by the ingress router. If false, unsettled deliveries to multicast addresses shall be rejected.",
+ "create": true,
+ "required": false,
+ "default": false
},
-
+ "defaultDistribution": {
+ "type": ["multicast", "closest", "balanced", "unavailable"],
+ "description": "Default forwarding treatment for any address without a specified treatment. multicast - one copy of each message delivered to all subscribers; closest - messages delivered to only the closest subscriber; balanced - messages delivered to one subscriber with load balanced across subscribers; unavailable - this address is unavailable, link attaches to an address of unavilable distribution will be rejected.",
+ "create": true,
+ "required": false,
+ "default": "balanced"
+ }
+ }
+ },
+
+ "routerStats": {
+ "description": "Overall router statistics.",
+ "extends": "operationalEntity",
+ "attributes": {
+ "id": {
+ "description":"Router's unique identity. The router will fail to start without id.",
+ "type": "string",
+ "required": false,
+ "create": true
+ },
+ "mode": {
--- End diff --
Mode is now in both router and routerStats and with create access in both instances. I don't think this belongs in routerStats.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org