[GitHub] [tvm] stoa commented on a change in pull request #9385: STM32: add as a new target

[GitBox <gi...@apache.org>]

stoa commented on a change in pull request #9385:
URL: https://github.com/apache/tvm/pull/9385#discussion_r739081718



##########
File path: python/tvm/target/target.py
##########
@@ -642,6 +642,27 @@ def create_tvm_options(cpu_ver, config):  # pylint: disable=unused-argument
 
     return Target(" ".join(["hexagon"] + args_list))
 
+STM32_SUPPORTED_MODELS = {
+    #"stm32H7xx": ["-device=arm_cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+    "stm32H7xx": ["-device=arm_cpu", "-mcpu=cortex-m7"],

Review comment:
       @areusch 
   Upon a second thought ...
   We first aligned with the CubeAI libraries that have a library per series. However, even within a given series there may be differences depending on the target board. So, it makes a better sense to distinguish targets per board ID. Additionally, the CubeMX also takes the board ID as a starting point. Finally, it will be easier for the user.
   Alternatively, if a user needs to use a model compiled for the same series but a different board, if they know what they are doing (memory sizes for example) - it will work as well.
   So, let's move to the board ID. And then this table will get large (dozens of entries or more). Perhaps we should imagine a separate file to keep it in ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org