You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/15 21:41:22 UTC
[GitHub] [cloudstack] weizhouapache commented on a change in pull request
#3808: reload dnsmasq instead of restart when adding new rules
weizhouapache commented on a change in pull request #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#discussion_r367121749
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -69,7 +69,7 @@ def process(self):
if not self.cl.is_redundant() or self.cl.is_master():
if restart_dnsmasq:
- CsHelper.service("dnsmasq", "restart")
+ CsHelper.service("dnsmasq", "reload")
Review comment:
@andrijapanicsb
"reload" works only if the service is started.
this is why we have line 74
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services