[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5348: Fix regression

[GitBox <gi...@apache.org>]

bdoyle0182 commented on code in PR #5348:
URL: https://github.com/apache/openwhisk/pull/5348#discussion_r1012208898


##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/ActivationClientProxy.scala:
##########
@@ -164,9 +166,12 @@ class ActivationClientProxy(
           stay()
 
         case _: ActionMismatch =>
-          logging.error(this, s"[${containerId.asString}] action version does not match: $action")
+          val errorMsg = s"[${containerId.asString}] action version does not match: $action"
+          logging.error(this, errorMsg)
           c.activationClient.close().andThen {
-            case _ => self ! ClientClosed
+            case _ =>

Review Comment:
   I was also seeing the issue for a test action that I frequently update every minute outside of the scheduler deployments. Does it stand to reason this was really the same issue and this will also fix that issue?
   
   The issue started happening I want to say around the same time of the October 13th commit that introduced the regression so it seems likely to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org