You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Adam Szita <sz...@cloudera.com> on 2016/09/19 10:50:28 UTC
Review Request 52026: PIG-4815: Adding support for xml format explain
on Spark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52026/
-----------------------------------------------------------
Review request for pig, Daniel Dai and liyun zhang.
Bugs: PIG-4815
https://issues.apache.org/jira/browse/PIG-4815
Repository: pig-git
Description
-------
PIG-4815: Adding support for xml format explain on Spark
Diffs
-----
src/org/apache/pig/backend/hadoop/executionengine/spark/SparkLauncher.java 5c5b5d6fb0984e1df28e1e2abaf91a4f4e2e6319
src/org/apache/pig/backend/hadoop/executionengine/spark/plan/XMLSparkPrinter.java PRE-CREATION
test/org/apache/pig/test/TestPigServer.java 8e286468b951170fcc7242f689684169e0cab6b6
Diff: https://reviews.apache.org/r/52026/diff/
Testing
-------
Extended TestPigServer.testExplainXmlComplex to cover spark exec mode of xml explain testing as well
Thanks,
Adam Szita
Re: Review Request 52026: PIG-4815: Adding support for xml format
explain on Spark
Posted by kelly zhang <li...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52026/#review150120
-----------------------------------------------------------
Some comment on spark part.
for the code modification in TestPigServer, let's wait Daniel or other committee 's review.
test/org/apache/pig/test/TestPigServer.java (line 595)
<https://reviews.apache.org/r/52026/#comment217983>
innerJoin rename to innerGroup
test/org/apache/pig/test/TestPigServer.java (line 597)
<https://reviews.apache.org/r/52026/#comment217990>
joinChildren rename to groupChildren
- kelly zhang
On Sept. 19, 2016, 10:50 a.m., Adam Szita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52026/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 10:50 a.m.)
>
>
> Review request for pig, Daniel Dai and liyun zhang.
>
>
> Bugs: PIG-4815
> https://issues.apache.org/jira/browse/PIG-4815
>
>
> Repository: pig-git
>
>
> Description
> -------
>
> PIG-4815: Adding support for xml format explain on Spark
>
>
> Diffs
> -----
>
> src/org/apache/pig/backend/hadoop/executionengine/spark/SparkLauncher.java 5c5b5d6fb0984e1df28e1e2abaf91a4f4e2e6319
> src/org/apache/pig/backend/hadoop/executionengine/spark/plan/XMLSparkPrinter.java PRE-CREATION
> test/org/apache/pig/test/TestPigServer.java 8e286468b951170fcc7242f689684169e0cab6b6
>
> Diff: https://reviews.apache.org/r/52026/diff/
>
>
> Testing
> -------
>
> Extended TestPigServer.testExplainXmlComplex to cover spark exec mode of xml explain testing as well
>
>
> Thanks,
>
> Adam Szita
>
>
Re: Review Request 52026: PIG-4815: Adding support for xml format
explain on Spark
Posted by Adam Szita <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52026/
-----------------------------------------------------------
(Updated Sept. 26, 2016, 8:17 a.m.)
Review request for pig, Daniel Dai and liyun zhang.
Bugs: PIG-4815
https://issues.apache.org/jira/browse/PIG-4815
Repository: pig-git
Description
-------
PIG-4815: Adding support for xml format explain on Spark
Diffs (updated)
-----
src/org/apache/pig/backend/hadoop/executionengine/spark/SparkLauncher.java 5c5b5d6fb0984e1df28e1e2abaf91a4f4e2e6319
src/org/apache/pig/backend/hadoop/executionengine/spark/plan/XMLSparkPrinter.java PRE-CREATION
test/org/apache/pig/test/TestPigServer.java 8e286468b951170fcc7242f689684169e0cab6b6
Diff: https://reviews.apache.org/r/52026/diff/
Testing
-------
Extended TestPigServer.testExplainXmlComplex to cover spark exec mode of xml explain testing as well
Thanks,
Adam Szita