You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by pluradj <gi...@git.apache.org> on 2016/06/03 17:07:58 UTC
[GitHub] incubator-tinkerpop pull request #328: use graph class as root class to find...
GitHub user pluradj opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/328
use graph class as root class to find temporary directory
https://issues.apache.org/jira/browse/TINKERPOP-1317
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pluradj/incubator-tinkerpop TINKERPOP-1317
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #328
----
commit 4b9bb87cd80bf6658e40090dd2cdb7b7b8f97122
Author: Jason Plurad <pl...@us.ibm.com>
Date: 2016-06-03T17:03:19Z
use graph class as root class to find temporary directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #328: TINKERPOP-1317: use graph class as root clas...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/328
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #328: TINKERPOP-1317: use graph class as root clas...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/328
Yes, looks good to me VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #328: TINKERPOP-1317: use graph class as root clas...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/328
@pluradj assuming @twilmes is voting +1 here pending the spelling fix, you will have your positive VOTE if you include a +1 yourself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #328: TINKERPOP-1317: use graph class as root clas...
Posted by analytically <gi...@git.apache.org>.
Github user analytically commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/328
Genius PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #328: TINKERPOP-1317: use graph class as root clas...
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/328
I always forget to vote for my own stuff. Thanks all.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #328: TINKERPOP-1317: use graph class as ro...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/328#discussion_r65783485
--- Diff: docs/src/dev/provider/index.asciidoc ---
@@ -505,6 +505,11 @@ off for the test suite (the Maven SureFire Plugin is configured this way by defa
include this setting, `<reuseForks>false</reuseForks>`, in the SureFire configuration if tests are failing in an
unexplainable way.
+TIP: When running the `gremlin-test` suite against your implementation, you may need to set `build.dir` as an
+envrionment variable, depending on your project layout. Some tests require this to find a writable directory for
--- End diff --
Tiny little typo here: "envrionment" -> "environment"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #328: TINKERPOP-1317: use graph class as ro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---