You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/08 03:17:21 UTC
[GitHub] [airflow] subkanthi opened a new pull request #20124: Added function in AWSAthenaHook to get s3 output query results file URI
subkanthi opened a new pull request #20124:
URL: https://github.com/apache/airflow/pull/20124
Added function in AWSAthenaHook to get s3 output query results file URI
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #20124: Added function in AWSAthenaHook to get s3 output query results file URI
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #20124:
URL: https://github.com/apache/airflow/pull/20124#discussion_r764543794
##########
File path: airflow/providers/amazon/aws/hooks/athena.py
##########
@@ -227,6 +227,29 @@ def poll_query_status(self, query_execution_id: str, max_tries: Optional[int] =
sleep(self.sleep_time)
return final_query_state
+ def get_output_location(self, query_execution_id: str) -> str:
+ """
+ Function to get the output location of the query results
+ in s3 uri format.
+
+ :param query_execution_id: Id of submitted athena query
+ :type query_execution_id: str
+ :return: str
+ """
+ output_location = None
+ if query_execution_id:
+ response = self.get_conn().get_query_execution(QueryExecutionId=query_execution_id)
+
+ if response:
+ try:
+ output_location = response['QueryExecution']['ResultConfiguration']['OutputLocation']
+ except KeyError:
+ self.log.error("Error retrieving OutputLocation")
+ else:
+ self.log.error("Invalid Query execution id")
Review comment:
```suggestion
raise ValueError("Invalid Query execution id")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #20124: Added function in AWSAthenaHook to get s3 output query results file URI
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #20124:
URL: https://github.com/apache/airflow/pull/20124#discussion_r764543412
##########
File path: airflow/providers/amazon/aws/hooks/athena.py
##########
@@ -227,6 +227,29 @@ def poll_query_status(self, query_execution_id: str, max_tries: Optional[int] =
sleep(self.sleep_time)
return final_query_state
+ def get_output_location(self, query_execution_id: str) -> str:
+ """
+ Function to get the output location of the query results
+ in s3 uri format.
+
+ :param query_execution_id: Id of submitted athena query
+ :type query_execution_id: str
+ :return: str
+ """
+ output_location = None
+ if query_execution_id:
+ response = self.get_conn().get_query_execution(QueryExecutionId=query_execution_id)
+
+ if response:
+ try:
+ output_location = response['QueryExecution']['ResultConfiguration']['OutputLocation']
+ except KeyError:
+ self.log.error("Error retrieving OutputLocation")
Review comment:
```suggestion
self.log.error("Error retrieving OutputLocation")
raise
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20124: Added function in AWSAthenaHook to get s3 output query results file URI
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20124:
URL: https://github.com/apache/airflow/pull/20124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org