You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/17 18:33:05 UTC

[jira] [Commented] (STORM-1913) Additions and Improvements for Trident RAS API

    [ https://issues.apache.org/jira/browse/STORM-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336645#comment-15336645 ] 

ASF GitHub Bot commented on STORM-1913:
---------------------------------------

GitHub user knusbaum opened a pull request:

    https://github.com/apache/storm/pull/1500

    STORM-1913: Additions and Improvements for Trident RAS API

    New behavior: 
    - Added a way to specify default values for operations in Trident
    - New behavior requires all components in group have same types of resources set (or defaults)
    - Added a way to specify resources for master-coord Spouts.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/knusbaum/incubator-storm STORM-1913

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1500
    
----
commit 50444bc15da839f0f88d94bcbd160601a6bdb373
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-06-17T17:59:06Z

    Working on cherry-pick

commit e197b0183c6a364b09f4d1b4c13694a4a6af1246
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-06-14T18:53:26Z

    Almost there.

commit 526178924e722bc9390c9453225a7811f1aa6e2e
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-06-17T18:10:04Z

    Doing pick.

commit 05b4aff8951265e5cfc3f58a7431db1a702aeddc
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-06-17T18:11:02Z

    Removing intermediate files.

commit 82e67600fc0cfb9c2110816508f4971e2e3f15ab
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-06-17T18:26:16Z

    Fixing stuff.

----


> Additions and Improvements for Trident RAS API
> ----------------------------------------------
>
>                 Key: STORM-1913
>                 URL: https://issues.apache.org/jira/browse/STORM-1913
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Kyle Nusbaum
>            Assignee: Kyle Nusbaum
>
> Trident's RAS API does not honor the following config values:
> {code}
> topology.component.resources.onheap.memory.mb
> topology.component.resources.offheap.memory.mb
> topology.component.cpu.pcore.percent
> {code}
> Trident does not receive the user's config as part of its builder API, so it does not know the value of these. Instead of altering the existing API (we want to remain backwards-compatible), add some new methods for dealing with this.
> There is also currently no way to set the master coord spouts' resources. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)