You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2025/05/12 01:36:05 UTC

[PR] Fix flink runner test [beam]

liferoad opened a new pull request, #34913:
URL: https://github.com/apache/beam/pull/34913

   Tests:
   ```
   ./gradlew :sdks:python:test-suites:portable:py39:flinkCompatibilityMatrixDOCKER
   ./gradlew :sdks:python:test-suites:portable:py39:flinkCompatibilityMatrixLOOPBACK
   ./gradlew :sdks:python:test-suites:portable:py39:flinkCompatibilityMatrixPROCESS 
   ```
   
   DOCKER and LOOPBACK are fine but PROCESS has this issue:
   __`java.lang.IllegalStateException: Process died with exit code 2`__: This is the most common error, affecting a majority of the failed tests across `FlinkRunnerTest`, `FlinkRunnerTestOptimized`, and `FlinkRunnerTestStreaming`. It indicates that the Flink process executing the pipeline is terminating unexpectedly.  Examples:
   
   - `test_assert_that`
   - `test_batch_pardo`
   - `test_create`
   - `test_group_by_key`
   - `test_pardo`
   - `test_sdf`
   - Many tests involving state, timers, and windowing.
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3099488132

   Assigning reviewers:
   
   R: @jrmccluskey for label python.
   R: @damccorm for label build.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3095122678

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3119590599

   > [!IMPORTANT]
   > **Installation incomplete:** to start using Gemini Code Assist, please ask the [organization owner(s)](https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/roles-in-an-organization#organization-owners) to visit the [Gemini Code Assist Admin Console](https://codeassist.google/code-review/login) and sign the Terms of Services.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad merged PR #34913:
URL: https://github.com/apache/beam/pull/34913


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3089377920

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #34913: Fix flink runner test
URL: https://github.com/apache/beam/pull/34913


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3094656928

   `./gradlew :sdks:python:test-suites:portable:py39:flinkCompatibilityMatrixDOCKER`: ================= 179 passed, 55 skipped in 2699.45s (0:44:59) =================


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3118812382

   > [!IMPORTANT]
   > **Installation incomplete:** to start using Gemini Code Assist, please ask the [organization owner(s)](https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/roles-in-an-organization#organization-owners) to visit the [Gemini Code Assist Admin Console](https://codeassist.google/code-review/login) and sign the Terms of Services.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3115284425

   > Thanks, had a couple of minor comments, but feel free to go ahead and merge when addressed.
   
   Got it. FYI. The workflow probably won't succeed with `flinkCompatibilityMatrixPROCESS`. I plan to merge it first and then debug  since I have some troubles to reliably run  `flinkCompatibilityMatrixPROCESS` on my machine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3062206141

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3094627210

   `./gradlew :sdks:python:test-suites:portable:py39:flinkCompatibilityMatrixLOOPBACK`: BUILD SUCCESSFUL in 18m 19s


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3098572848

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/34913?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 56.54%. Comparing base [(`8eba198`)](https://app.codecov.io/gh/apache/beam/commit/8eba198cefc88d945789832c5209765f984dbe92?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`29c0dd7`)](https://app.codecov.io/gh/apache/beam/commit/29c0dd77bd23f9be721060a0cb61d974c865569b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 9 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             master   #34913    +/-   ##
   ==========================================
     Coverage     56.54%   56.54%            
     Complexity     3378     3378            
   ==========================================
     Files          1205     1205            
     Lines        183660   183844   +184     
     Branches       3475     3475            
   ==========================================
   + Hits         103847   103952   +105     
   - Misses        76495    76574    +79     
     Partials       3318     3318            
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/34913/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/beam/pull/34913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.66% <ø> (-0.06%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/34913?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #34913:
URL: https://github.com/apache/beam/pull/34913#discussion_r2222708098


##########
.github/workflows/beam_PostCommit_Python_Portable_Flink.yml:
##########
@@ -0,0 +1,101 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PostCommit Python Portable Flink

Review Comment:
   Noting that this workflow won't execute until merged and we can't run it since its from a fork - this is fine for this instance, but in the future please consider using a branch off of the main `apache/beam` repo when adding new workflows or modifying existing ones so that we can run the workflow as part of the pr process.



##########
.github/workflows/beam_PostCommit_Python_Portable_Flink.yml:
##########
@@ -0,0 +1,101 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PostCommit Python Portable Flink
+
+on:
+  schedule:
+    - cron: '30 5/6 * * *'
+  pull_request_target:
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Python_Portable_Flink.json']
+  workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+  actions: write
+  pull-requests: write
+  checks: write
+  contents: read
+  deployments: read
+  id-token: none
+  issues: write
+  discussions: read
+  packages: read
+  pages: read
+  repository-projects: read
+  security-events: read
+  statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+  group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}'
+  cancel-in-progress: true
+
+env:
+  DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+  GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+  GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+  beam_PostCommit_Python_Portable_Flink:
+    if: |
+      (github.event_name == 'schedule' && github.repository == 'apache/beam') ||
+      github.event_name == 'workflow_dispatch' ||
+      github.event_name == 'pull_request_target' ||
+      startsWith(github.event.comment.body, 'Run Python Portable Flink')

Review Comment:
   ```suggestion
         github.event_name == 'pull_request_target')
   ```
   
   There is no comment trigger on this workflow (and we don't add them for postcommits in general)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flink runner test [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #34913:
URL: https://github.com/apache/beam/pull/34913#issuecomment-3092567490

   `./gradlew :sdks:python:test-suites:portable:py39:flinkCompatibilityMatrixDOCKER`
   
   ```
   =========================== short test summary info ============================
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_batch_pardo_fusion_break
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_batch_to_element_pardo
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_expand_kafka_read
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_flattened_side_input
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_gbk_side_input
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_multimap_multiside_input
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_multimap_side_input
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_multimap_side_input_type_coercion
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_pack_combiners
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_pardo_side_input_dependencies
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_pardo_side_inputs
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_pardo_unfusable_side_inputs
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_pardo_unfusable_side_inputs_with_separation
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_pardo_windowed_side_inputs
   FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestStreaming::test_sdf_synthetic_source
   =========== 15 failed, 164 passed, 55 skipped in 2829.80s (0:47:09) ============
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org