You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "SchopenhauerZhang (via GitHub)" <gi...@apache.org> on 2023/05/09 08:44:32 UTC
[GitHub] [rocketmq] SchopenhauerZhang opened a new pull request, #6723: [ISSUE #6722]Bugfix timer thread has error when timer not enable
SchopenhauerZhang opened a new pull request, #6723:
URL: https://github.com/apache/rocketmq/pull/6723
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6722
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6723: [ISSUE #6722]Bugfix timer thread has error when timer not enable
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6723:
URL: https://github.com/apache/rocketmq/pull/6723#issuecomment-1541410734
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6723](https://app.codecov.io/gh/apache/rocketmq/pull/6723?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27e9aa8) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/f33ac2a3ece691bc15cb875726b5ad054a60ae22?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f33ac2a) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #6723 +/- ##
=============================================
+ Coverage 42.89% 42.91% +0.02%
+ Complexity 9007 9006 -1
=============================================
Files 1113 1113
Lines 78591 78593 +2
Branches 10221 10223 +2
=============================================
+ Hits 33709 33726 +17
+ Misses 40659 40646 -13
+ Partials 4223 4221 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/broker/BrokerController.java](https://app.codecov.io/gh/apache/rocketmq/pull/6723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `46.39% <0.00%> (+2.84%)` | :arrow_up: |
| [...apache/rocketmq/broker/slave/SlaveSynchronize.java](https://app.codecov.io/gh/apache/rocketmq/pull/6723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc2xhdmUvU2xhdmVTeW5jaHJvbml6ZS5qYXZh) | `4.16% <0.00%> (-0.03%)` | :arrow_down: |
... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6723/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] SchopenhauerZhang commented on pull request #6723: [ISSUE #6722]Bugfix timer thread has error when timer not enable
Posted by "SchopenhauerZhang (via GitHub)" <gi...@apache.org>.
SchopenhauerZhang commented on PR #6723:
URL: https://github.com/apache/rocketmq/pull/6723#issuecomment-1541390462
done,commit:27e9aa8;
format code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #6723: [ISSUE #6722]Bugfix timer thread has error when timer not enable
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #6723:
URL: https://github.com/apache/rocketmq/pull/6723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #6723: [ISSUE #6722]Bugfix timer thread has error when timer not enable
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #6723:
URL: https://github.com/apache/rocketmq/pull/6723#issuecomment-1541173224
The code is ok, code style need to format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org