[GitHub] [incubator-doris] decster commented on pull request #3762: [Memory Engine] MemTablet creation and compatibility handling in BE

[GitBox <gi...@apache.org>]

decster commented on pull request #3762:
URL: https://github.com/apache/incubator-doris/pull/3762#issuecomment-640343996


   > Hi @decster , in your comment, you said `When TabletManager::get_tablet is called, only return Tablet, if the underlying tablet is MemTablet, return an error, this keeps the initial code changes small.`
   > 
   > But i didn't see the code change related to it?
   
   the related change is in tablet_manager TabletManager::_get_tablet_unlocked
   
   ```
       if (ret->is_memory()) {
           LOG(FATAL) << "_get_tablet_unlocked get MemTablet";
           return TabletSharedPtr();
       }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org