[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #14297: [Broker] Fix NPE in internalSkipMessages

[GitBox <gi...@apache.org>]

Demogorgon314 commented on a change in pull request #14297:
URL: https://github.com/apache/pulsar/pull/14297#discussion_r806804924



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiSubscriptionTest.java
##########
@@ -20,36 +20,39 @@
 
 import static org.testng.Assert.assertEquals;
 import static org.testng.Assert.expectThrows;
+import java.util.UUID;
 import javax.ws.rs.core.Response;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest;
 import org.apache.pulsar.client.admin.PulsarAdminException;
 import org.apache.pulsar.client.api.MessageId;
-import org.testng.annotations.AfterMethod;
-import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
 @Slf4j
 @Test(groups = "broker-admin")
-public class AdminApiSubscriptionTest  extends MockedPulsarServiceBaseTest {
-    @BeforeMethod
+public class AdminApiSubscriptionTest extends MockedPulsarServiceBaseTest {
+    @BeforeClass
     @Override
     public void setup() throws Exception {
         super.internalSetup();
         super.setupDefaultTenantAndNamespace();
     }
 
-    @AfterMethod(alwaysRun = true)
+    @BeforeClass

Review comment:
       Should be `@AfterClass`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org