You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/04/01 21:13:15 UTC
[GitHub] [trafficcontrol] rob05c opened a new pull request #5705: Fix TO client urlsig path
rob05c opened a new pull request #5705:
URL: https://github.com/apache/trafficcontrol/pull/5705
Fixes the TO client urlsig path being wrong.
This is critical, because ORT uses this client function now, causing ORT url_sig keys to break.
- [x] This PR is not related to any other Issue
## Which Traffic Control components are affected by this PR?
- Traffic Ops Client
- Traffic Ops ORT
## What is the best way to verify this PR?
Run tests. Run ORT, and verify url_sig files are generated correctly. Write an app to use the TO client urlsig function, verify it returns the keys successfully.
## If this is a bug fix, what versions of Traffic Control are affected?
ORT is critically broken in `master and 5.1. Client v2-client and v3-client functions have been broken since inception (but nothing inside ATS used the function, as far as I know).
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [ ] This PR includes documentation OR I have explained why documentation is unnecessary
- [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #5705: Fix TO client urlsig path
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #5705:
URL: https://github.com/apache/trafficcontrol/pull/5705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on pull request #5705: Fix TO client urlsig path
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #5705:
URL: https://github.com/apache/trafficcontrol/pull/5705#issuecomment-812182520
Don't merge yet, this is effectively a draft, but I want to see the checks run, and drafts don't run them apparently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a change in pull request #5705: Fix TO client urlsig path
Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #5705:
URL: https://github.com/apache/trafficcontrol/pull/5705#discussion_r605980480
##########
File path: traffic_ops/testing/api/v2/deliveryservices_test.go
##########
@@ -32,6 +32,7 @@ import (
func TestDeliveryServices(t *testing.T) {
WithObjs(t, []TCObj{CDNs, Types, Tenants, Users, Parameters, Profiles, Statuses, Divisions, Regions, PhysLocations, CacheGroups, Servers, DeliveryServices}, func() {
GetAccessibleToTest(t)
+ GetTestDeliveryServicesURLSigKeys(t)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c removed a comment on pull request #5705: Fix TO client urlsig path
Posted by GitBox <gi...@apache.org>.
rob05c removed a comment on pull request #5705:
URL: https://github.com/apache/trafficcontrol/pull/5705#issuecomment-812182520
Don't merge yet, this is effectively a draft, but I want to see the checks run, and drafts don't run them apparently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5705: Fix TO client urlsig path
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #5705:
URL: https://github.com/apache/trafficcontrol/pull/5705#discussion_r605974920
##########
File path: traffic_ops/testing/api/v2/deliveryservices_test.go
##########
@@ -32,6 +32,7 @@ import (
func TestDeliveryServices(t *testing.T) {
WithObjs(t, []TCObj{CDNs, Types, Tenants, Users, Parameters, Profiles, Statuses, Divisions, Regions, PhysLocations, CacheGroups, Servers, DeliveryServices}, func() {
GetAccessibleToTest(t)
+ GetTestDeliveryServicesURLSigKeys(t)
Review comment:
Since this new test depends on Riak, it should only be run `if includeSystemTests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org