[GitHub] [dubbo] chickenlj commented on a diff in pull request #11521: Tri grpc compatibility

["chickenlj (via GitHub)" <gi...@apache.org>]

chickenlj commented on code in PR #11521:
URL: https://github.com/apache/dubbo/pull/11521#discussion_r1103568803


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/GrpcHttp2Protocol.java:
##########
@@ -0,0 +1,7 @@
+package org.apache.dubbo.rpc.protocol.tri;

Review Comment:
   Also the following 3 files.



##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/GrpcHttp2Protocol.java:
##########
@@ -0,0 +1,7 @@
+package org.apache.dubbo.rpc.protocol.tri;

Review Comment:
   Missing Apache License header here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org