You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajani Karuturi <ra...@gmail.com> on 2014/06/11 11:18:47 UTC

Review Request 22454: Fixed few coverity reported issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22454/
-----------------------------------------------------------

Review request for cloudstack, daan Hoogland, Koushik Das, and Santhosh Edukulla.


Repository: cloudstack-git


Description
-------

unused assignments, boxing and unboxing of values etc.


Diffs
-----

  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 55736f9 

Diff: https://reviews.apache.org/r/22454/diff/


Testing
-------


Thanks,

Rajani Karuturi


Re: Review Request 22454: Fixed few coverity reported issues

Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22454/#review45466
-----------------------------------------------------------



server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/22454/#comment80325>

    Based on the method checkIpRange(), startIp is mandatory but endIp is optional. Is all callers of checkPodAttributes enforcing that?



server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/22454/#comment80324>

    Method signature is listByPodIdDcId(long, long). Parameter podId is of type Long, so it needs to be passed correctly.


- Koushik Das


On June 11, 2014, 9:18 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22454/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 9:18 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Koushik Das, and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> unused assignments, boxing and unboxing of values etc.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 55736f9 
> 
> Diff: https://reviews.apache.org/r/22454/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Re: Review Request 22454: Fixed few coverity reported issues

Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22454/#review45470
-----------------------------------------------------------



server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/22454/#comment80329>

    startIp is never null. There is a check in the caller to see if startIp is null. 
    Even if this check exists here, it is of no use as it will fail with NPE in checkIpRange on the first line itself if the startip is null.



server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/22454/#comment80331>

    Long.valueOf() gives you another Long. its basically converting Long to Long. 
    We should do podId.longValue() to pass long.
    auto unboxing will take care it.


- Rajani Karuturi


On June 11, 2014, 9:18 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22454/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 9:18 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Koushik Das, and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> unused assignments, boxing and unboxing of values etc.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 55736f9 
> 
> Diff: https://reviews.apache.org/r/22454/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Re: Review Request 22454: Fixed few coverity reported issues

Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22454/#review45476
-----------------------------------------------------------



server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/22454/#comment80335>

    podid wont be null/invalid as it is already checked in the dispatcher layer and hence it can be safely unboxed without a NPE.


- Rajani Karuturi


On June 11, 2014, 9:18 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22454/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 9:18 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Koushik Das, and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> unused assignments, boxing and unboxing of values etc.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 55736f9 
> 
> Diff: https://reviews.apache.org/r/22454/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Re: Review Request 22454: Fixed few coverity reported issues

Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22454/#review45478
-----------------------------------------------------------

Ship it!


master -> 2482da8cbfcf3f01b54f59149e252f5899f9c4a9
4.4-forward -> 32a7d5d387804374c38ed568e2dcd1e9c543873c

- Koushik Das


On June 11, 2014, 9:18 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22454/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 9:18 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Koushik Das, and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> unused assignments, boxing and unboxing of values etc.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 55736f9 
> 
> Diff: https://reviews.apache.org/r/22454/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>