You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kobayashi Noritada <no...@dolphin.c.u-tokyo.ac.jp> on 2005/02/25 07:45:56 UTC
[PATCH] add more gettext support for subversion/libsvn_repos/load.c
Hi,
This patch adds more gettext support for subversion/libsvn_repos/load.c.
Thanks,
- nori
Log:
Add more gettext support for subversion/libsvn_repos/load.c.
Index: subversion/libsvn_repos/load.c
===================================================================
--- subversion/libsvn_repos/load.c (revision 13145)
+++ subversion/libsvn_repos/load.c (working copy)
@@ -992,14 +992,14 @@
case svn_node_action_change:
{
SVN_ERR (svn_stream_printf (pb->outstream, pool,
- " * editing path : %s ...",
+ _(" * editing path : %s ..."),
nb->path));
break;
}
case svn_node_action_delete:
{
SVN_ERR (svn_stream_printf (pb->outstream, pool,
- " * deleting path : %s ...",
+ _(" * deleting path : %s ..."),
nb->path));
SVN_ERR (svn_fs_delete (rb->txn_root, nb->path, pool));
break;
@@ -1007,7 +1007,7 @@
case svn_node_action_add:
{
SVN_ERR (svn_stream_printf (pb->outstream, pool,
- " * adding path : %s ...",
+ _(" * adding path : %s ..."),
nb->path));
SVN_ERR (maybe_add_with_history (nb, rb, pool));
@@ -1016,7 +1016,7 @@
case svn_node_action_replace:
{
SVN_ERR (svn_stream_printf (pb->outstream, pool,
- " * replacing path : %s ...",
+ _(" * replacing path : %s ..."),
nb->path));
SVN_ERR (svn_fs_delete (rb->txn_root, nb->path, pool));
@@ -1162,7 +1162,7 @@
struct parse_baton *pb = rb->pb;
apr_size_t len = 7;
- SVN_ERR (svn_stream_write (pb->outstream, " done.\n", &len));
+ SVN_ERR (svn_stream_write (pb->outstream, _(" done.\n"), &len));
return SVN_NO_ERROR;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] add more gettext support for
subversion/libsvn_repos/load.c
Posted by Kobayashi Noritada <no...@dolphin.c.u-tokyo.ac.jp>.
Hi,
Thank you for your approval. Committed at r13150.
> > This patch adds more gettext support for subversion/libsvn_repos/load.c.
>
> +1, please commit. BTW: Is there any reason not to combine the other patch
> with this one? (I know, you already committed it... Just curious.)
r13150 is merely marking strings with _() without modifying those strings
and enabling translation, although r13149 is accompanying little change in
the code and dividing a string into two.
So, I thought they are "unrelated" and followed the description in the
HACKING:
A patch submission should contain one logical change; please don't mix
N unrelated changes in one submission -- send N separate emails
instead.
Actually I found both at once in checking Issue 1997 fixed. :-)
Regards,
--
|: Noritada KOBAYASHI
|: Dept. of General Systems Studies,
|: Graduate School of Arts and Sciences, Univ. of Tokyo
|: E-mail: nori1@dolphin.c.u-tokyo.ac.jp (preferable)
|: nori@esa.c.u-tokyo.ac.jp
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] add more gettext support for subversion/libsvn_repos/load.c
Posted by Erik Huelsmann <e....@gmx.net>.
> Hi,
>
> This patch adds more gettext support for subversion/libsvn_repos/load.c.
+1, please commit. BTW: Is there any reason not to combine the other patch
with this one? (I know, you already committed it... Just curious.)
oh, my committers name: dionisos.
bye,
Erik.
>
> Thanks,
>
> - nori
>
> Log:
> Add more gettext support for subversion/libsvn_repos/load.c.
>
> Index: subversion/libsvn_repos/load.c
> ===================================================================
> --- subversion/libsvn_repos/load.c (revision 13145)
> +++ subversion/libsvn_repos/load.c (working copy)
> @@ -992,14 +992,14 @@
> case svn_node_action_change:
> {
> SVN_ERR (svn_stream_printf (pb->outstream, pool,
> - " * editing path : %s ...",
> + _(" * editing path : %s ..."),
> nb->path));
> break;
> }
> case svn_node_action_delete:
> {
> SVN_ERR (svn_stream_printf (pb->outstream, pool,
> - " * deleting path : %s ...",
> + _(" * deleting path : %s ..."),
> nb->path));
> SVN_ERR (svn_fs_delete (rb->txn_root, nb->path, pool));
> break;
> @@ -1007,7 +1007,7 @@
> case svn_node_action_add:
> {
> SVN_ERR (svn_stream_printf (pb->outstream, pool,
> - " * adding path : %s ...",
> + _(" * adding path : %s ..."),
> nb->path));
>
> SVN_ERR (maybe_add_with_history (nb, rb, pool));
> @@ -1016,7 +1016,7 @@
> case svn_node_action_replace:
> {
> SVN_ERR (svn_stream_printf (pb->outstream, pool,
> - " * replacing path : %s ...",
> + _(" * replacing path : %s ..."),
> nb->path));
>
> SVN_ERR (svn_fs_delete (rb->txn_root, nb->path, pool));
> @@ -1162,7 +1162,7 @@
> struct parse_baton *pb = rb->pb;
> apr_size_t len = 7;
>
> - SVN_ERR (svn_stream_write (pb->outstream, " done.\n", &len));
> + SVN_ERR (svn_stream_write (pb->outstream, _(" done.\n"), &len));
>
> return SVN_NO_ERROR;
> }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
--
DSL Komplett von GMX +++ Superg�nstig und stressfrei einsteigen!
AKTION "Kein Einrichtungspreis" nutzen: http://www.gmx.net/de/go/dsl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org